Fix ListObjectsV2 pagination snapshot inconsistency#409
Merged
bootjp merged 2 commits intofeature/s3-implfrom Mar 22, 2026
Merged
Fix ListObjectsV2 pagination snapshot inconsistency#409bootjp merged 2 commits intofeature/s3-implfrom
bootjp merged 2 commits intofeature/s3-implfrom
Conversation
Open
…ent readTS Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com> Agent-Logs-Url: https://github.com/bootjp/elastickv/sessions/328b2498-848d-4fc7-bfe6-b34c1f95b849
Copilot
AI
changed the title
[WIP] Add S3 adapter
Fix ListObjectsV2 pagination snapshot inconsistency
Mar 22, 2026
bootjp
approved these changes
Mar 22, 2026
bootjp
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListObjectsV2loaded bucket metadata at an initialreadTS, then silently replacedreadTSwithtoken.ReadTSfrom the continuation token — leavingmeta.Generationderived from a different snapshot than the actual scan. This could cause incorrect token validation or mis-keyed scans when bucket state changed between pages.Changes
adapter/s3.go—listObjectsV2: Reorder initialization so the continuation token is parsed first, the finalreadTSis resolved (token.ReadTSif present, otherwises.readTS()), and bucket metadata is loaded at that resolved timestamp before any token validation occurs.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.