kv: zero CommitTS when StartTS is auto-assigned in coordinators#413
Merged
bootjp merged 2 commits intofeature/s3-implfrom Mar 23, 2026
Merged
kv: zero CommitTS when StartTS is auto-assigned in coordinators#413bootjp merged 2 commits intofeature/s3-implfrom
bootjp merged 2 commits intofeature/s3-implfrom
Conversation
Merged
Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com> Agent-Logs-Url: https://github.com/bootjp/elastickv/sessions/4953ec80-5e46-4a9f-8aad-5babc83f3f41
Copilot
AI
changed the title
[WIP] Add s3 adapter
kv: zero CommitTS when StartTS is auto-assigned in coordinators
Mar 23, 2026
bootjp
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
StartTS == 0and a coordinator auto-assigns it, any caller-providedCommitTSwas still forwarded intodispatchTxn. Since the freshly-issuedStartTSis generated from the HLC at dispatch time, a pre-suppliedCommitTScan easily satisfyCommitTS <= StartTS, producing an invalid transaction or observing an arbitrary external timestamp into the clock.Changes
kv/coordinator.go: Zeroreqs.CommitTSalongsidereqs.StartTSassignment whenStartTS == 0, sodispatchTxngenerates both timestamps consistently.kv/sharded_coordinator.go: Same fix in the sharded path — clearCommitTSwhenever the coordinator assignsStartTS.This mirrors the existing
redirect()logic, which already clearsCommitTSwhen forwarding a txn without aStartTS:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.