Repository navigation
Show post-backup notification after tasks finish - #2571
Merged
m3nu merged 1 commit intoOct 5, 2026
Merged
Conversation
post_backup_tasks() queued the prune, archive refresh, check and compact jobs and showed "Post Backup Tasks successful" right away, before any of them had run. Now the notification is shown once all queued jobs have finished, as an error if one of them failed. With no follow-up jobs, it's still shown immediately. This also fixes the message never being translated, since the profile name was formatted into the string before tr(). Fixes borgbase#2562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-backup notification was shown before the queued tasks had finished.
This changes it to wait until all post-backup tasks are complete and report failure if any task fails. When there are no post-backup tasks to run, the notification is shown immediately as before.
Also fixes the notification message not being translated correctly and adds tests for these cases.
The macOS/Python 3.10 unit job crashes with a segfault in
test_recording_a_skip_emits_jobs_changed. The same crash occurs on unchangedmaster, so it is unrelated to this PR.Branch run: https://github.com/ahmershahdev/vorta/actions/runs/37209880973
Master run: https://github.com/ahmershahdev/vorta/actions/runs/37210485257
Fixes #2562