Syncing from upstream OCA/contract (16.0)#959
Merged
Conversation
Mainly to avoid `ModuleNotFoundError: No module named 'pkg_resources'` when running the `setuptools-odoo` pre-commit hook, as v3.1.8 was bitten by the removal of `pkg_resources` from recent versions of `setuptools`. This was fixed by v1.38 of `oca-addons-repo-template` by updating `setuptools-odoo` to v3.3.2. See #1421 for more more information.
This includes a couple of `_do_auto_pay` tests which were missing a `test_target_state` context (added in later commits), and a `_pay_invoice` test which did not clear the invoice's residual amount.
So that they can pay refunds etc. no matter what account in arbitrarily chosen when creating an invoice from a subscription. This avoids "UserError: The company bank account linked to this invoice is not trusted, please double-check and trust it before confirming, or remove it" in `TestSubscriptionOCA.test_subscription_oca_sub8_workflow`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #959 +/- ##
==========================================
+ Coverage 93.12% 93.18% +0.06%
==========================================
Files 145 145
Lines 5075 5076 +1
Branches 439 439
==========================================
+ Hits 4726 4730 +4
+ Misses 279 277 -2
+ Partials 70 69 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot