Repository navigation
fix(json): distinguish absent object members from null - #263
Open
joo00der (jihtsan) wants to merge 1 commit into
Open
joo00der (jihtsan) wants to merge 1 commit into
joo00der (jihtsan) wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes #261. Missing object members contribute score0 before recursive value comparison in Python and TypeScript. An omitted nullable member no longer receives a perfect identical-structure grade. Own-property checks preserve the JSON member contract for prototype-looking names. Keep union weighting, root null/undefined behavior, shared custom scorers, skipped sub-scores, arrays and string parsing unchanged. No async traversal redesign or bool/numeric scope expansion.
New regressions cover both directions, weighted records, nested objects/arrays, parsed JSON strings, null/null, empty records, false/zero and custom shared scorers. Original-code results: Python8fail10pass; TS8fail12pass. Final targets: Python18pass, TS20pass. Independent Standards/Spec reviews on415c8cbd22b1e77bb09210e5da7700b80e4f9847 have no remaining findings.
Validation
Validated locally with Python3.13.12/uv.lock dev+scipy and pnpm10.33.0 frozen lock/Node24.22.1. Hosted CI, real-provider/model success and other runtime/platform matrices are unverified. No real keys or paid quota were used; full-suite success is not claimed. Maintainers own approval/merge/release.
AI assistance: OpenAI Codex researched, implemented and independently reviewed this change.