Repository navigation
fix(python): honor explicit None in partial scorers - #267
Open
Vinsy Moyya (vinsymoyya) wants to merge 1 commit into
Open
Vinsy Moyya (vinsymoyya) wants to merge 1 commit into
Vinsy Moyya (vinsymoyya) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266.
Python partial scorers previously discarded an explicit
expected=Noneand graded against the bound answer instead. Use a private omission sentinel ineval,eval_async, and callable shorthand so explicit null overrides the bound default while omission retains it. Required-answer validation and ordinary overrides remain intact.The change is limited to
partial.pyand its existing test file. It does not change the underlying scorers' normalization or default arguments.Validation on Python 3.12.13:
twine check dist/*passes for both artifacts. The unpacked wheel contains the exact patched source and templates and passes sync, async, callable, and preset-template construction checks.git diff --checkpasses.The combined repository-hook invocation fails during Prettier's Node environment setup:
nodeenvcannot parse the upstream27.0.0-alpha.0.0.0version. The Python hooks above were therefore run individually. The complete repository hook run is not claimed to pass.Hosted workflows currently report
action_requiredand require maintainer approval before execution. The full provider-dependent test suite and runtime matrix are not verified. No model requests or credentials were used for the reproduction or new tests.