Allow emitFile filenames that start with a period#211
Merged
Conversation
Owner
|
Thank you for PR, Does it work on windows? |
Contributor
Author
|
@btd Thanks for the callout. It looks like Rollup doesn't normalize paths. I've updated to an approach using a regex that checks for I've not got a windows machine to easily test this on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current check for "you can't have absolute or relative paths in the
filenameproperty" makes it impossible to create the filename.vite/stats.htmleven though that not a relative path and thus is a valid filename to pass into emitFile.This PR updates the check so the relative path checks looks for files that start with
./or../rather than any filename that starts with a.