Fix subagent tool name normalization(#130)#131
Merged
frostming merged 2 commits intobubbuild:mainfrom Mar 22, 2026
Merged
Conversation
frostming
approved these changes
Mar 22, 2026
Collaborator
|
Please fix the lint error |
frostming
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130
Summary
This PR fixes tool-name handling for
subagent.allowed_tools.Previously,
run_subagent()forwardedallowed_toolsas raw strings. That meantmodel-facing aliases such as
schedule_listwere not normalized back to runtimeregistry names such as
schedule.list, which could later surface as a confusingruntime error like:
Root Cause
subagent was doing raw set filtering:
set(param.allowed_tools) - {"subagent"}
But Bub exposes tool names to models using underscore aliases, while the runtime
registry keeps dotted names. As a result:
Changes
Tests
Added/updated regression coverage for:
Verification
uv run pytest -q tests/test_tools.py tests/test_subagent_tool.py