You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(debug-files): share directory scan / empty-input policy / upload runner across symbol types #71
Follow-up to #69 / #70 (ELF now accepts directories).
Context
Every debug-files upload --type … flow has its own directory walker (WalkDir in several places in src/cli/debug_files.rs) and, for several types, its own identify → dedup → pack → register → PUT loop. Review of #70 turned up policy details that are easy to get wrong per walker, and the other types may not share the fixes:
Audit + shared walker. Document how each type's walker differs today, pin the current exit codes/behaviour with tests, then extract one scanner (name match incl. --extension, symlink policy, ordering, unreadable-root rule) and one empty-input policy. Behaviour-preserving; any exit-code change called out in the changelog (exit codes are a public contract).
Optional: generic upload runner for the identify → keep-best-per-identity → bounded-concurrency pack/register/PUT pattern (ELF, Rust-ELF, PDB, dSYM, source maps), only if step 1 shows enough duplication to justify the risk.
Non-goals
Per-format identification (src/symbols/*) and wire shapes stay as-is; zip input stays an ELF-only adapter.
Activity