Skip to content

Note the 7.x wrapper alignment in the changelog - #21

Merged
krassx merged 1 commit into
cursor/upm-package-scaffoldfrom
wrapper/changelog
Oct 9, 2026
Merged

krassx merged 1 commit into
cursor/upm-package-scaffoldfrom
wrapper/changelog

Conversation

@krassx

@krassx krassx commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Documents the 7.x wrapper bridge alignment under [0.1.0] - Unreleased in CHANGELOG.md:

  • Pre-launch native wrapper registration (Android UnityWrapperProvider, iOS +load)
  • Wrapper-channel submit for host logs and game-supplied network events
  • Secure-rectangle pull buffer (getSecureRectangles / secureRectanglesForDisplay:)
  • Fail-closed filter callbacks (throwing filters drop the event)
  • Severity 0 unset / nullable IReport.Severity
  • New facade methods: DeleteCollectedDataOnDevice, CreateReport, AddBreadcrumb, AddNetworkEvent

Test plan

  • Docs-only change; verify CHANGELOG.md formatting and bullet accuracy against merged wrapper work.

Made with Cursor

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep code review — PR #21 (3ebd406)

Docs-only change: six bullets under [0.1.0] - Unreleased / ### Added describing the merged 7.x wrapper alignment. Reviewed against the surrounding implementation (registration, channel submit, secure-rect pull, filters, severity wire, public facade), not the diff in isolation.

No P0–P3 findings. Every listed claim matches the current code.

Claim check

Bullet Verdict
Pre-launch wrapper registration Accurate. Android UnityWrapperProvider is a merged ContentProvider with initOrder="200" and Bugsee.setWrapper. iOS BugseeUnityWrapper +load does the same. C# Launch refines context (refineContext / _bugsee_ensure_wrapper) and does not construct a second wrapper.
Wrapper-channel submit Accurate. Host logs use UnityWrapper.channelLog / _bugsee_channel_log (HostLogForwarder → ChannelLog). Game network events use channelAddNetwork / _bugsee_channel_network, not the public native log/addNetworkEvent APIs. The bullet correctly does not claim breadcrumbs go through the channel (Android AddBreadcrumb still calls public Bugsee.addBreadcrumb).
Secure-rectangle pull buffer Accurate. AddSecureRectangle / RemoveSecureRectangle / RemoveAllSecureRectangles push a versioned packed snapshot; native getSecureRectangles and secureRectanglesForDisplay: return the last pushed copy (default {1, 0} if nothing was pushed).
Fail-closed filters Accurate. Throwing network/log/breadcrumb filters drop: iOS FilterCompletion.OnThrow == Drop; Android EventFilterProxy completes with null. Null filters still keep, which this bullet does not contradict.
Severity 0 unset Accurate. IssueSeverity.VeryLow = 1; TryFromWire(0) fails; IReport.Severity is IssueSeverity?. iOS create-report JSON omits "severity" when _dto.severity == 0.
Public facade Accurate. DeleteCollectedDataOnDevice, CreateReport, AddBreadcrumb, and AddNetworkEvent are on Bugsee.

CI on this SHA is green (wrapper-policy, Android wrapper tests, iOS bridge tests). Did not re-run those suites locally.


Findings

None.

Summary

  1. Overall risk: Low
  2. Merge recommendation: Approve — safe to merge as a changelog note of already-landed wrapper work.
  3. Most important issues to fix: None.
  4. Positive: The bullets are specific (JNI/P-Invoke names, initOrder 200, fail-closed vs keep-on-null, severity 0 vs VeryLow) and do not over-claim platform differences such as Android breadcrumbs still using the public native API.
Open in Web View Automation 

Sent by Cursor Automation: Bugsee code review

@krassx
krassx merged commit e43391b into cursor/upm-package-scaffold Oct 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant