Repository navigation
fix(skills-sync): use the skills-sync environment; no PR for no-op upstream commits - #80
Merged
Merged
Conversation
… for no-op upstream commits - Declare `environment: skills-sync` on the job. The app private key is an environment secret there; the merged workflow lacked the declaration, so the key was empty and the app-token step was skipped. - `mirror-skills --update` moved the pin to bugsee-for-ai main on every run, so any upstream commit (CI, README, ...) opened a sync PR whose only change was scripts/skills-source.json. Now the pin moves only when the generated files change; the older pin keeps producing identical files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Change-Id: Ide7ed6aa6fc94a78ef3e502e3d7e248dea2ca09c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78, found on its first run (https://github.com/bugsee/docs/actions/runs/37785104403).
Problems
skills-syncenvironment, but the merged workflow lackedenvironment: skills-sync(my last commit on feat(ai): generate the SDK agent skills from bugsee-for-ai #78 missed the merge). The job sawSYNC_APP_PRIVATE_KEYas empty, skipped "Mint a short-lived GitHub App token" and fell back toGITHUB_TOKEN.--updatemoved the pin to bugsee-for-aimainon every run, so any upstream commit — even CI-only ones like the two that triggered chore(skills): sync agent skills from bugsee-for-ai #79 — produced a sync PR whose only change isscripts/skills-source.json.Fix
environment: skills-syncon the job (+ comment).mirror-skills --updatenow moves the pin only when the generated files change. The old pin keeps producing identical files, so--checkis unaffected. Verified against upstreamebcf4e2:0 files changed … pin kept.Verified
--update(pin kept),--checkOK, mirror unit tests 8/8, workflow YAML parses.#79 can be closed after this merges (it only bumps the pin).
🤖 Generated with Claude Code