Repository navigation
ci(docs): fail the build on broken links and anchors - #81
Merged
Merged
Conversation
onBrokenLinks/onBrokenAnchors were 'warn', so CI could not catch a dead internal link (the review found common /sdk/<platform>/ URLs returning 404 with nothing flagging it). The site currently has none, so switching to 'throw' costs nothing. Verified that the build exits 1 for a planted broken link and for a planted broken anchor. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Change-Id: Ied97ba3470257049131349b1b44c9589372b7217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding #6 of the 2026-10-07 public-repo review:
onBrokenLinks: 'warn'meant CI could not catch dead internal links (common/sdk/<platform>/URLs 404'd in production).The 404s themselves were fixed by #77 (client redirects). I checked the live site: all 9
/sdk/<platform>/roots and the old Android v7 paths now answer 200, and every docs link in the website repo'smainresolves.This PR
onBrokenLinksandonBrokenAnchors→'throw'.Verified
throw(0 broken links, 0 broken anchors), so this is free today.npm run buildexit 1 (probe reverted).🤖 Generated with Claude Code