Repository navigation
fix: pass GITHUB_TOKEN to the Check links CI step - #1001
Open
Pranav-IIITM wants to merge 1 commit into
Open
Pranav-IIITM wants to merge 1 commit into
Pranav-IIITM wants to merge 1 commit into
Conversation
The Check links step looked up the latest pack version from the GitHub API without a token, so it was rate limited on shared runners and failed at random. Pass the token like the Test and Build steps do, and print a clear message when the version lookup fails. Signed-off-by: Pranav-IIITM <jogdandpranav2007@gmail.com>
Contributor
Author
|
Evidence of the flaky failure, from CI runs on #999, which doesn't touch CI or the Makefile:
Runs 1 and 2 used identical code and the same workflow, yet the version lookup failed in one and worked in the other. That fits the anonymous GitHub API rate limit on shared runners: Check links makes the request without |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1000
What changed
packversion can't be looked up, the build now says so clearly and suggests how to fix it, instead of failing with a confusingjqparse error.Why
Check links was looking up the latest
packversion without a token. On GitHub's shared runners that request can hit the anonymous rate limit, which made thebuildjob fail at random on PRs that had nothing wrong with them. Contributors can't re-run the job themselves, so they had to push empty commits just to get a fresh run.With this change, CI should stop failing for reasons unrelated to the PR, and if the lookup does fail, the error says what went wrong.