Skip to content

fix: replace leftover Bootstrap 4 class names - #995

Merged
AidanDelaney merged 1 commit into
buildpacks:mainfrom
Pranav-IIITM:fix/talks-bootstrap5-classes
Oct 26, 2026
Merged

AidanDelaney merged 1 commit into
buildpacks:mainfrom
Pranav-IIITM:fix/talks-bootstrap5-classes

Conversation

@Pranav-IIITM

Copy link
Copy Markdown
Contributor

Summary

Restores styling that silently stopped working when the site moved to Bootstrap 5 in #806:

  • Talks section on /docs: the Description and Resources labels under the video carousel are bold again, and resource buttons have space between them instead of touching.
  • Community page calendar: the "* Events displayed in local time." note is italic again, and the extra gap before the .ics download link is gone.
  • Docs sidebar: nested items are indented as originally designed, so it's easier to tell which page sits under which section.

Closes #994

Before After
image image

Notes for Reviewers

  • Only class names change, 8 in total across 4 templates. Each old Bootstrap 4 name is replaced by its Bootstrap 5 equivalent, which applies the same style. No content changes.
  • The header class (text-lg-left → text-lg-start) has no visible effect. It's renamed so no Bootstrap 4 names are left in these files.
  • The sidebar change is the most noticeable one. It restores the original indentation, which has been missing since the Bootstrap 5 upgrade. If the tighter look is preferred now, the class can be removed instead.

@Pranav-IIITM
Pranav-IIITM requested a review from a team as a code owner October 23, 2026 10:43

@AidanDelaney AidanDelaney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update

@AidanDelaney
AidanDelaney enabled auto-merge (squash) October 26, 2026 10:21
…ebar and header

These templates still used Bootstrap 4 class names that Bootstrap 5 no
longer provides, so their styles silently stopped applying:

- talks: Description and Resources labels were no longer bold, and
  resource buttons had no gap between them (font-weight-bold -> fw-bold,
  mr-2 -> me-2)
- calendar: the local time note was no longer italic and the .ics list
  kept an extra left margin (font-italic -> fst-italic, ml-0 -> ms-0)
- sidebar: nested items lost part of their indentation (ml-2 -> ms-2)
- header: text-lg-left -> text-lg-start (no visible change)

Signed-off-by: Pranav-IIITM <jogdandpranav2007@gmail.com>
@AidanDelaney
AidanDelaney force-pushed the fix/talks-bootstrap5-classes branch from eab8bda to 0ad4dfc Compare October 26, 2026 10:21
@AidanDelaney
AidanDelaney merged commit e14c644 into buildpacks:main Oct 26, 2026
3 of 4 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 26, 2026
…ebar and header (#995)

These templates still used Bootstrap 4 class names that Bootstrap 5 no
longer provides, so their styles silently stopped applying:

- talks: Description and Resources labels were no longer bold, and
  resource buttons had no gap between them (font-weight-bold -> fw-bold,
  mr-2 -> me-2)
- calendar: the local time note was no longer italic and the .ics list
  kept an extra left margin (font-italic -> fst-italic, ml-0 -> ms-0)
- sidebar: nested items lost part of their indentation (ml-2 -> ms-2)
- header: text-lg-left -> text-lg-start (no visible change)

Signed-off-by: Pranav-IIITM <jogdandpranav2007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Talks, community calendar and docs sidebar lost some of their styling after the Bootstrap 5 upgrade

2 participants