Skip to content

Narrow report action row subscriptions with useOnyxState - #90

Draft
sosek108 wants to merge 1 commit into
feature/onyx-store-useonyxstate-recutfrom
perf/3114-rows-useonyxstate-on-104690
Draft

sosek108 wants to merge 1 commit into
feature/onyx-store-useonyxstate-recutfrom
perf/3114-rows-useonyxstate-on-104690

Conversation

@sosek108

@sosek108 sosek108 commented Nov 2, 2026

Copy link
Copy Markdown

Explanation of Change

This builds on the useOnyxState hook from this branch and narrows what each report action row in a chat subscribes to, so writes that don't affect a row no longer re-render it.

The rows used to read whole Onyx keys and re-render on any change to them. Now the original report lookup, the avatars' sender lookup and the list's transaction visibility read only the entry they need through useOnyxState. A transaction write in another report no longer re-renders every row and avatar in an open chat. The row avatars reuse the data the row has already computed, instead of looking it up a second time. The list's pagination ignores report fields that only track last activity, like the last read time or the last message preview, because they don't change which actions are shown.

A small helper keeps the Search snapshot behaviour of useOnyx, so rows rendered in Search still read from the snapshot instead of live data.

With the current Onyx head of this branch, sending a message in a chat with about 60 mounted rows on web (interleaved A/B, about 19 sends per leg) took 143 ms instead of 151 ms against the same branch without these changes.

Fixed Issues

$
PROPOSAL:

Tests

  1. Open a chat with many messages, including expense previews and a thread
  2. Verify every message shows the correct avatar, including delegate and Concierge avatars
  3. Send a message and verify it appears at the bottom with your avatar
  4. Open an expense report with one expense and verify its actions and the expense's actions are both shown
  5. Open a thread and verify the parent message is shown at the top
  6. Edit an expense in another report and verify the open chat still shows correctly
  7. Open Search, open a report from the results and verify its messages and avatars show correctly
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Send a message in a chat and verify it appears with your avatar and pending style
  3. Go online and verify the message stays in place without duplicates

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant