Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This builds on the
useOnyxStatehook from this branch and narrows what each report action row in a chat subscribes to, so writes that don't affect a row no longer re-render it.The rows used to read whole Onyx keys and re-render on any change to them. Now the original report lookup, the avatars' sender lookup and the list's transaction visibility read only the entry they need through
useOnyxState. A transaction write in another report no longer re-renders every row and avatar in an open chat. The row avatars reuse the data the row has already computed, instead of looking it up a second time. The list's pagination ignores report fields that only track last activity, like the last read time or the last message preview, because they don't change which actions are shown.A small helper keeps the Search snapshot behaviour of
useOnyx, so rows rendered in Search still read from the snapshot instead of live data.With the current Onyx head of this branch, sending a message in a chat with about 60 mounted rows on web (interleaved A/B, about 19 sends per leg) took 143 ms instead of 151 ms against the same branch without these changes.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari