Skip to content

Build the reportID to name map once with useOnyxState - #91

Draft
sosek108 wants to merge 1 commit into
feature/onyx-store-useonyxstate-recutfrom
perf/3040-report-id-name-map-uos
Draft

sosek108 wants to merge 1 commit into
feature/onyx-store-useonyxstate-recutfrom
perf/3040-report-id-name-map-uos

Conversation

@sosek108

@sosek108 sosek108 commented Nov 6, 2026

Copy link
Copy Markdown

Explanation of Change

This builds on the useOnyxState hook from this branch and stops useReportIDToNameMap from rebuilding its map on every report write.

The hook maps every reportID to its name so the composer, message editing, the context menu and the room and workspace description pages can turn #room mentions into links. It used to subscribe to the whole report collection and build a new map with one entry per report each time any report changed, separately in every mounted consumer. Sending a message writes the report, so each send rebuilt the map several times and re-rendered its consumers, even though no name changed.

Now the hook reads the report collection through useOnyxState and keeps one map shared by all consumers. When the collection changes, it compares each report with the previous one by reference and rebuilds the map only when a name or reportID changed or a report was removed. Otherwise it returns the same map, and an identity check keeps the consumers from re-rendering. The hook reads live report data, also on Search screens; for a name map the live collection holds every name the Search snapshot has.

Sending a message on web with a large account (4x CPU throttling, interleaved A/B, 20 sends per leg) took 824 ms instead of 907 ms against the same branch without this change, and a repeat run with the leg order reversed gave the same direction (861 ms instead of 983 ms). Running the unchanged build on both legs showed no difference.

Fixed Issues

$
PROPOSAL:

Tests

  1. Open any chat, send a message that mentions a room you belong to, e.g. hello #admins
  2. Hover the message, open the context menu and choose Edit comment
  3. Verify the composer shows the mention as #admins, not as a raw link or a reportID
  4. Rename the room, then edit the same message again
  5. Verify the composer shows the mention with the new room name
  6. Open a room you can edit, set its description to see #admins and save, then open the description again
  7. Verify the description field shows see #admins
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Open any chat, send a message that mentions a room you belong to, e.g. hello #admins
  3. Open the context menu on the message and choose Edit comment
  4. Verify the composer shows the mention as #admins

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant