Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This builds on the
useOnyxStatehook from this branch and stopsuseReportIDToNameMapfrom rebuilding its map on every report write.The hook maps every reportID to its name so the composer, message editing, the context menu and the room and workspace description pages can turn
#roommentions into links. It used to subscribe to the whole report collection and build a new map with one entry per report each time any report changed, separately in every mounted consumer. Sending a message writes the report, so each send rebuilt the map several times and re-rendered its consumers, even though no name changed.Now the hook reads the report collection through
useOnyxStateand keeps one map shared by all consumers. When the collection changes, it compares each report with the previous one by reference and rebuilds the map only when a name or reportID changed or a report was removed. Otherwise it returns the same map, and an identity check keeps the consumers from re-rendering. The hook reads live report data, also on Search screens; for a name map the live collection holds every name the Search snapshot has.Sending a message on web with a large account (4x CPU throttling, interleaved A/B, 20 sends per leg) took 824 ms instead of 907 ms against the same branch without this change, and a repeat run with the leg order reversed gave the same direction (861 ms instead of 983 ms). Running the unchanged build on both legs showed no difference.
Fixed Issues
$
PROPOSAL:
Tests
hello #admins#admins, not as a raw link or a reportIDsee #adminsand save, then open the description againsee #adminsOffline tests
hello #admins#adminsQA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari