Repository navigation
Conversation
There was a problem hiding this comment.
1 issue found across 34 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/contracts/src/cli-flags.ts">
<violation number="1" location="packages/contracts/src/cli-flags.ts:126">
P3: This doc comment repeats the option's prose, which the header of this file says must live only on the `FlagDefinition` (flag-definitions-action.ts already has it). Remove the block and keep the bare field; the '#1047 sibling' ticket pointer goes with it.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Coverage failed on an eager-closure ratchet: the new evidence module joined the command-runtime entry closure as a static edge. It now loads behind a function-scoped dynamic import (type import kept separate, so types cost nothing), with a follow-up fixing an intermediate scope mistake — verified green locally (typecheck/lint, 135 tests). 🤖 Generated with Claude Code |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
At 6606bb9, Right now
This change alters live dispatch: it bypasses the native ref fast path and the direct-iOS fused route, and brackets the tap with two captures and a 150 ms sleep. The PR body lists typecheck, lint, unit tests and progress checks at an older head (69032ca), with no device run. After the two fixes above, please run through the CLI on one iOS simulator and one Android emulator, against a screen with a static region or keypad. The run needs to show: Not blocking, take or leave: the flag could be a Could the readback be smaller? After splitting out b37da26, put The open review threads still apply, apart from one. P2: absent |
|
This now conflicts with main at 6606bb9. Please rebase onto main. The two defects and the live run from the earlier review still apply. |
|
Tracked in #4318, group C (new public surface). We're reviewing the six feature PRs together for coherence and for performance impact on paths that don't use them, and we'll post a direction there. Please hold changes here until then. |
|
Thanks @strzhao. We reviewed this with the rest of group C in #4318. It mixes two changes that should land separately.
What the visual feature needs:
Could you open the split PR for part 1 and an issue for part 2? |
6606bb9 to
7a61db9
Compare
|
Rebased onto main (through 0.21.37). The only conflict was the interaction metadata field list — the plan now spreads main's |
|
Two defects from the earlier review (6606bb9, #4297 (comment)) are still open at 7a61db9, and the PR has no device run yet. CI is green: 19 of 19 checks pass. It cannot catch the two defects below, because every readback test injects
Live dispatch also changed. Under the flag, the native ref fast path and the direct-iOS fused route are bypassed, and two captures plus a 150 ms wait bracket the tap (interactions.ts#L184). Nothing proves the readback works on a real backend, and the first defect shows that it currently does not. After both fixes, please run through the CLI on one iOS simulator and one Android emulator. Show Not blocking, take or leave: the before-frame capture now sits between the at-rest confirmation in The review threads on the missing inconclusive-when-absent note in the docs (r4497036453), the missing catch after dispatch (r4497036487), the tap stub that records nothing (r4497036494), the repo guard's Before merge, please open the design issue for the screenshot readback, since the baseline half shipped in #4338, then fix the two defects and post the live iOS and Android run. |
|
Progress at ffff797, with the decision carried to #4509. Defect 2 fixed. Nothing after a resolved dispatch throws out of the evidence lane: the comparison runs inside a catch that yields no evidence, cleanups are caught, the after-frame settle honors the request signal, and both frames decode in the codec worker ( Defect 1 is the design decision. #4509 carries it: admit a capture operation on touch routes, or refuse pre-dispatch where no binding exists. Per the 11-08 direction the design issue comes first; the binding follows its outcome, and the live iOS/Android runs follow the binding (before it lands, the flag cannot report on a shipped surface — which is defect 1 itself). Taken as well: the docs' inconclusive-when-absent sentence, and r4497036570 resolved as not applying. The remaining threads (r4497036453, r4497036487, r4497036494, r4497036501, r4497036514) are fixed at this head; r4497036508 routes to #4509. Title and body retitle to the readback once defect 1 lands and the flag reports for real. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
I reviewed ffff797 against my earlier review at #4297 (comment). The capture-failure, corrupted-frame and docs concerns are fixed. The silent no-op on daemon routes is not, and there is still no live device run. The daemon touch backend is built without Under the flag, the native ref fast path and the direct-iOS fused route are bypassed (interactions.ts:154). Two captures and a 150 ms wait now bracket the tap. This changes live dispatch, and no device run exists at this head. After the fix above, please run through the CLI on one iOS simulator and one Android emulator: Of the other open threads, the abort-handling thread still applies, and so do three lower-priority ones. The dynamic-import thread does not apply, because the import is evaluated once and then served from the module cache: #4297 (comment). The threads on the docs sentence, the capture-failure catch, the capture-failure test, the metadata CI is green with 19 of 19 checks passing, but no CI route exercises the daemon touch route with the flag, so green does not cover the first issue. Before merge, the daemon binding or refusal needs to land with its route test, and then the live iOS and Android runs need to be posted. |
|
Defect 1 is enforced at the one place the daemon admits the flag: The CLI live runs you specified are meaningful once the flag reports on a shipped surface — under the refusal that is the typed refusal JSON on the daemon route, which I can attach next, and the runtime-lane runs (effective key, dead region, runtime-ref click) follow the #4509 binding decision. Title/body retitle to the readback with the next push. |
|
Thanks for the update. At 434e4ad the earlier findings on the delivered-tap tests, the after-frame error handling, the missing-descriptor guard and the PNG decode are fixed. One problem remains, and it is a new one. All 19 checks pass, but no job drives the daemon press/click route with the flag and asserts Every daemon press and click with Not blocking, and you can take or leave these: the guarantee matrix still marks Could the PR avoid shipping an advertised flag whose only production behavior is a refusal? Landing the capture binding first would remove the refusal, the dead eligibility guard and the pass-through, and the existing bracket would work on the real route. Otherwise, removing the flag from every surface and the matrix and parking the runtime lane until #4509 decides would avoid carrying about 209 production lines that no production route reaches. Could the baseline also fold into the post-action observation plan as a third evidence kind, so it has one owner? Of the open inline threads, the abort/deadline thread still applies (it must be fixed when a capture binds), as do the unreachable direct-iOS guard, the Before merge, the advertised flag and the daemon route must agree, either by binding the capture or by removing the flag from every surface and the matrix. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
The capture now binds into the touch backend — route A, as you laid out. At e62ff68 (the binding at The binding. Route test. The plan and single-ref forms both drive the route; a capture-less device refuses with the stamped verdict, and the capture-backed lane is exercised by the evidence test suite (backend member present → bracket runs → Live runs (iOS simulator, PIN-pad rig; JSON excerpts in
The guarantees matrix keeps the runtime rows enforced (the route now reaches them); the abort/deadline fix landed with the binding (the settle sleep takes the request signal), and the unreachable-guard/pass-through notes dissolved with the refusal's deletion. 793 interaction/daemon tests, typecheck, lint, and fallow pass at the pushed head. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Thanks for the update. At f49ebe6 the readback now reaches the daemon route and the iOS simulator run shows The evidence still has gaps (doc line 36). It covers only the iOS simulator, and its dead-region run reads The dead-tap false positive is probably caused by the readback itself (screenshot-diff-evidence.ts:135). Each frame is a separate The new refusal contradicts the docs (interaction-touch-press.ts:57). When the device owner declares no The frame file is a copy of a daemon helper (screenshot-diff-evidence.ts:121). The inline mkdtemp, path.join and The readback capture input is too thin (interaction-runtime.ts:225). It sends only No daemon test covers the bound route (interaction-touch-press-admission.test.ts:355). The contract scenarios and There is leftover debug output (interaction-runtime.ts:65). An unconditional Not blocking: Could this be simpler? The daemon could hand the touch backend one typed On the open inline threads: these still stand and need no restatement: the capture input, the console.error, the abort signal (it still passes Before merge: make the readback's status-bar handling identical in both frames, then post the iOS dead-region run that reads |
There was a problem hiding this comment.
All reported issues were addressed across 11 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Requires human review: Auto-approval blocked because this review re-detected 3 unresolved issues already reported by Cubic.
View guided diff | Re-trigger cubic
|
Thanks for the update. I reviewed f66aa4b against the earlier review, including the delta and the CI logs. The readback route and capture-input wiring from the earlier review are now in place, but the status-bar problem is still open, so the dead-tap case can still report a change. There are no conflicts. The new No daemon test covers the bound readback route. The only daemon test that sets The readback still builds its own This is a device-facing change, and the evidence doc (ios-screenshot-readback-2026-11-15.md:36) is unchanged by the delta. No device has yet shown Checks show Repo Guards failing on one Fallow complexity breach in Not blocking: if the status-bar fix does not use Simplicity question: the delta adds a second These open inline threads still apply. The higher-priority ones are signal handling on abort, missing surface and preferred backend, per-frame status-bar normalization, temp-file cleanup without catch and stderr route-flags print. Eight lower-priority threads also still apply. These threads no longer apply and can be resolved: r4577119988 because Before merge, please make the readback's own pixels identical in both frames with one status-bar decision wired at |
|
This branch now conflicts with main at f66aa4b. Please rebase onto main and push along with the fixes from the earlier review, and I will re-check the new head. |
|
The status-bar question and the Android runs are addressed at b76194c (+ e62ff68 for the iOS evidence). Dead-tap root cause — you were right, and it wasn't the clock. With Android runs (Redmi K60, the different capture owner): effective key The refusal vs the docs: the refusal is deleted — the flag is advisory again on every surface, exactly as the five texts describe. A device whose owner declares no capture dispatches the tap with no evidence (route test pins dispatch + no The daemon-route test with an owner-declared capture (two different PNGs, |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…eadback A coordinate press on a surface the accessibility tree cannot describe — a PIN keypad whose keys never reach the tree — dispatches fine, leaves --verify's node digest flat whether or not the digit was entered, and reports success. Repeated attempts walk toward a device lockout with no signal in any response. The flag brackets the dispatch with two lightweight screenshots and compares them on pixels instead of nodes: screenshotDiff carries changedFromBefore and the changed-pixel ratio. A matching pair adds a response warning, because the dispatch may have had no visible effect; the action itself still succeeds. Best-effort like --verify evidence: a failed capture or a screenshot-less backend drops the field and claims nothing about the screen. The flag routes press/click through the runtime path (the native ref fast path and the fused direct-iOS route never reach the bracket), and the decode stack loads behind function-scoped dynamic imports so the flag-less fast path pays nothing. Co-Authored-By: Claude Code <noreply@anthropic.com>
…nshot-diff The compact workflow card has a byte ratchet (cli-help.test.ts) with no headroom for a new sentence, and the flag's owning help already carries the full guidance: the flag definition's usage text renders in "Command flags:" for press/click, and the metadata field description documents the PIN-keypad case for the Node SDK and MCP schemas. Co-Authored-By: Claude Code <noreply@anthropic.com>
…apCommand The before-frame capture, its dispatch-failure cleanup, and the pair outcome composition each added a branch to a function the complexity gate already watches. dispatchWithScreenshotPair owns the bracket lifecycle and attachScreenshotPairOutcome owns the result composition, so tapCommand reads as dispatch-plus-observation again; the reader gate's positional table flattens the same way. Co-Authored-By: Claude Code <noreply@anthropic.com>
The bracket lifecycle moved behind dispatchWithScreenshotPair, so the two frame helpers no longer need exports; the dead-export gate reads them as unused module surface. Co-Authored-By: Claude Code <noreply@anthropic.com>
…matrix, settle the after-frame, and document the out-of-tree readback Review fixes for the press/click --expect-screenshot-diff PR: - The guarantee matrix (ADR 0011) gains the screenshotDiffEvidence row: runtime cells on runtime-selector/runtime-ref/coordinate scoped to press/click, a delegated cell on native-ref, and inapplicable cells on the paths the flag cannot reach. The three waivers that named only --verify/--settle as the opt-in post-action evidence routes now name this flag too. Each enforced cell carries a contract scenario, and the shared harness replays a solid-color frame plan. - The after-frame waits 150ms past the dispatch reply before it is captured: the reaction the flag asks about can render frames after the transport round trip returns, and an immediate frame would read an effective tap as unchanged. The flag help text, field descriptions, and schema prose state the timing instead of leaving it blank. - commands.md names the flag where it teaches that a successful press is not proof of effect: a PIN keypad target is the case --verify cannot answer, since it compares empty trees. - Gate drift the PR introduced: the new capture-kit export joins the layering manifest baseline, and the flag descriptor gate moves to test/repo-guards/ (a repo-level guard on command descriptors, not a module's unit test — R84 test-colocation). Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
…ed tap Nothing after a resolved dispatch throws out of the evidence lane anymore: a decode, read, import or cleanup failure yields no evidence, because a throwing readback reported a delivered tap as failed and a PIN caller would re-enter the digit. The after-frame settle honors the request signal. Both frames decode in the codec worker, the guard audits a missing descriptor instead of skipping it, the docs say the readback is best-effort, and the delivered-tap tests record the tap. Co-Authored-By: Claude Code <noreply@anthropic.com>
…l a capture binds The touch routes admit the flag but bind no screenshot capture, so the flag was a silent no-op on every shipped surface. The refusal lives at the one place the daemon admits the flag: typed reason screenshot-readback-unavailable, dispatched no, and the callstack#4509 decision owns when the capture binds instead. Co-Authored-By: Claude Code <noreply@anthropic.com>
--expect-screenshot-diff now works on the daemon press and click routes: the route admits the flag, binds the device's screenshot capture through the screenshot lane's own plan admission, and hands it to the interaction backend, so the readback bracket runs instead of returning no evidence. A device whose owner declares no capture still refuses before dispatch, with the screenshot lane's refusal stamped dispatched no. The refusal guard is gone; callstack#4509 keeps the any-pixel threshold question. Co-Authored-By: Claude Code <noreply@anthropic.com>
The interaction route's artifacts policy refuses temp files by design, so the readback's before and after frames never got created and the flag answered with silence even after the capture bound. The lane owns its frame directory (mkdtemp plus cleanup with the frame) instead of asking the route's adapter. A device whose owner declares no capture still refuses before dispatch with the screenshot lane's refusal, stamped dispatched no. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
…xt, and restore the temp-file port The readback frame now carries the input the screenshot command would build for this request: the session's app identity, the simulator boot-check knowledge, and the runner execution from the dispatch context. The shared temp-file implementation moves into runtime-artifacts, the interaction route's policy opts in, and the lane goes back to the runtime's createCommandTempFile. The advisory case on a capture-less device pins dispatch-with-no-evidence. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
The status bar moves without the dispatch causing it — a clock ticks on every platform, and an iOS simulator's per-frame normalization can leave residue in one frame — so the comparison ignores its band and the dead tap reads false with the advisory warning on both platforms. Co-Authored-By: Claude Code <noreply@anthropic.com>
… the rebase Co-Authored-By: Claude Code <noreply@anthropic.com>
…unction Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
…dget The rebase restored main's newer press help and metadata prose, which pushed the always-loaded tools over the byte budget with the readback field added. The press cliDetail and the metadata plan sentence carry the compact form; the full contract stays in ADR 0014, commands.md, and the help. The budget still exceeds by about 100 bytes with the field's own schema — the remaining gap is the callstack#4509/advertised-flag decision's to fund. Co-Authored-By: Claude Code <noreply@anthropic.com>
…budget callstack#4296's plan prose pushed the always-loaded tools over the budget on main, and the readback field added on top. The press description and the field text carry the compact forms; the full contract lives in ADR 0014, commands.md, the help line, and the cliDetail. The meta test drops the leftover debug dumps. Co-Authored-By: Claude Code <noreply@anthropic.com>
… capture The excluded region is exactly the region the device itself changes between frames, so the capture owner declares it per device class and the lane compares over the rest: ScreenshotCaptureFacts gains statusBarTopHeightShare (apple per appleOs, android, harmonyos; web, macOS, and TV declare none), the bound screenshot backend returns it beside the rotation, and the readback's single compare call takes the band from the before-frame's own facts. The ratio's denominator is the compared region, and both normalizeStatusBar requests go: a readback frame is captured by the screenshot command's exported capture builder, with no options hand-built in the interaction route. Schema text and commands.md say outside the device status bar, and the lane regression pins the band pair, the just-below pair, the compared-region denominator, and the band-less platform; the daemon-route pair runs the real command surface against an owner-declared capture and goes red when the forwarding drops. Co-Authored-By: Claude Code <noreply@anthropic.com>
Three full-JSON runs replace the stale sections: the mid-screen dead tap on the iPhone 17 Pro and on the Redmi K60 both read false at a flat zero with the outside-the-status-bar warning, and the iPad header-tab press reads true on a two-orders-smaller ratio than the old band's noise floor. The old runs stay, marked with the heads and band semantics they were recorded at. Co-Authored-By: Claude Code <noreply@anthropic.com>
A canceled request ends the pair after the settle instead of capturing the after-frame; the pixel loop is bounded by the declared frame bytes instead of the buffer length; the temp-file owner's doc names its real opt-ins; the policy test pins the allowTempFiles branch end to end; the readback flag's cli-flags comment stops restating the flag definition; the contract scenario asserts the tap really crossed; and the fused iOS route gains the daemon test that keeps a click with the readback flag on the runtime path. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
The route test drives the real command surface, so the daemon declares the workspace sibling its test support imports, the tsconfig references it, and the stray scratch test file goes away. Layering passes, and the lockfile records the link. Co-Authored-By: Claude Code <noreply@anthropic.com>
49a943c to
39c404d
Compare
|
Thanks for the update. At 39c404d the debug-line, cleanup, abort, loop-bound and capture-routing items from the earlier review (#4297 (comment)) are mostly fixed, but the status-bar exclusion still does not work on the daemon route. CI is green (19 checks, 0 failing), but it cannot see this gap. The PR also has merge conflicts with main, and it should not merge until the problems below are fixed and live runs are posted. The daemon route drops the status-bar band. No test covers the band on the production route. Both daemon-route readback tests mock The user-facing text promises behavior the daemon route does not deliver. The schema text (index.ts:90 and :93), the flag usage, the warning and The live evidence does not exercise the band. The iOS doc says the dead tap reads 0 because the clock sits inside the owner-declared band (ios-screenshot-readback-2026-11-15.md:29), and the Android doc says the same at line 28. Production used band 0, so the runs read 0 only because no glyph redrew during the window. Neither doc cites the SHA it ran at. At a pushed head with the fix, please post the full Not blocking, and you can take or leave these: On the open inline threads: the threads on the field text in metadata.ts:92, the dropped press ref-list sentence and the cut intervalMs clause still apply. Also still applying are the abort signal check, the iOS mid-screen dead tap, the iOS doc band claim, the Android doc band claim and the /tmp debug writes. These threads no longer apply and can be resolved: readbackCapture forwarding is forwarded and pinned by a test; capture through the session surface now passes appBundleId, surface and requestId; unguarded cleanup is an The landscape and TV band shares are computed, not measured. To merge, please return the capture facts at |
2026-11-16: live runs on both platforms are attached — iOS (
docs/evidence/ios-screenshot-readback-2026-11-15.md: effective key true/0.0037, runtime-ref click true/0.0134, dead region false + warning at heade62ff686eafter the status-bar band exclusion) and Android (docs/evidence/android-screenshot-readback-2026-11-16.mdat headb76194c1e: effective key true/0.389, dead region false + warning, runtime-ref click true/0.056). The dead-tap root cause was the per-frame status-bar normalization leaving residue in one frame; the readback now excludes the status-bar band from the ratio, and both platforms prove the dead tap reads false with the advisory warning.2026-11-15: the capture now binds on the daemon touch routes — this PR delivers the readback (
--expect-screenshot-diff) on press/click; the baseline half shipped in #4338. Live runs below and indocs/evidence/ios-screenshot-readback-2026-11-15.mdat heade62ff686e.Summary
A coordinate press on a PIN pad reported success while the digit never entered and the remaining-attempts counter ticked down — the no-op guard's baseline had fallen back to an older tree, exactly the blind spot its own comment admits. Two changes: the coordinate lane now takes a guaranteed fresh pre-tree when the session baseline is stale, and
press --expect-screenshot-diffadds an out-of-tree readback that compares a lightweight before/after screenshot digest, so "tapped, nothing happened" is a reported effect instead of a discovery.22 files changed (baseline freshness, expect readback, output fields, tests).
Validation
pnpm run typecheck,pnpm run lint, post-action-observation and interaction tests, integration-progress--check, fallow, freerange: pass locally.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.