Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 10 files
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/platform-apple/src/core/screenshot.ts:283 |
🆕 Stale single-panel count goes unreported when the beside-capture read cannot identify a panel |
Reviewed with this repository's own Sentinel configuration (cb335952017e).
Review of 38ae500c · 16.11.2026 17:17 UTC
Apex Sentinel · ✅ Approve
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/platform-apple/src/core/display-inventory.ts:137 |
Suppressed unresolved diagnostic still leaves hints that tell the operator to read it |
Reviewed with this repository's own Sentinel configuration (b3c1a3c8abd9).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 38ae500. The verdict and the full list are in the summary comment.
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 5cd9828. The verdict and the full list are in the summary comment.
|
This PR is ready at 8ee29b5, and the checks pass (22 pass, 2 skipped, 0 failing) with no conflicts. Nothing blocks merge. Not blocking, and fine to take or leave: when the caller aborts on a scoped-set simulator, readGuestPanelTable throws instead of returning probe-canceled, so the claim in the PR body and test comment holds only for the default set; the grace wait in captureWithFallback runs inside the status-bar hold and could move after it; settledWithin now shares a name with a different function in provider-app-log-poller.ts; and a rotation read that misses the 250 ms grace now logs a warn-level probe-canceled at display-inventory.ts:138, which may be noisy under load. The timing, rotation and Duo fold runs were taken at 38ae500; the later diff changes only diagnostics, tests and docs. |
…enshot A simulator whose panel table already resolved to one integrated panel never names a display, so its per-capture panel table read only supplies the display rotation. Start that read beside simctl io screenshot and attach its rotation within a 250 ms grace after the image is written; a later read is aborted and the rotation is absent, as the screenshot contract already states. Multi-panel and unknown devices keep the sequential read, so a folded device still names its lit panel. The resolved panel count moves from the foldable rotation module into the display inventory, which records it on every resolved read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A read beside a single-panel capture that resolves a named panel now emits apple_display_single_panel_count_stale. ADR 0025 records that only the panel count is kept and that a single-panel table read runs beside the capture. The runner-fallback inventory tests pin the sequential path explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…verdict cache The rotation read test now asserts the 2 s budget and drives the 250 ms grace with fake timers. ADR 0025 states that a stale single-panel verdict sends one capture without --display, and that the resolved read replaces the verdict so the next capture names the lit panel. The cache is described as a multi-panel verdict, not a count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ts diagnostic Fold and orientation hints point at apple_display_inventory_unresolved, so a caller-canceled read must still emit it. The diagnostic fires again for every unresolved read; a read whose caller aborted it reports reason probe-canceled instead of probe-failed, without the toolchain hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…names no panel A read beside a single-panel capture that refuses with capture-panel-unidentified resolved a multi-panel table too, so that capture also went out without --display. It now emits apple_display_single_panel_count_stale. The refused read already records the multi-panel verdict, so the next capture reads the table first; a test pins that. Other read failures stay silent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8ee29b5 to
d385f4b
Compare
…ed reads The single-panel rotation grace now runs after the simulator's status bar is released, so the lock is not held for metadata. A canceled panel table read reports apple_display_inventory_unresolved at info level. The shared grace helper is renamed resolvedWithinGrace so it no longer shares a name with the app-log poller's own helper, and the canceled-read test states that only a CoreDevice read reaches the fold hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
R11 pins capture-kit's export list; the shared settledWithin helper that Android and Apple screenshots use is a new deliberate subpath. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d385f4b to
284db40
Compare
|
Rebased onto main after #4603. In the Android screenshot, the helper rotation still comes first, and the dumpsys fallback now uses the shared grace helper. Applied all four notes in 8a2dbe3 (head 284db40):
Locally, the focused Android and Apple screenshot, display-inventory, foldable and ADR-citation tests pass, along with lint and typecheck. |
|
Live evidence at head
Rotation across orientation changes in Safari: 24/24 shots matched the image shape with plain screenshots, and 24/24 with the status-bar override. iPhone Duo, 5 fold cycles each way: 0 of 20 PNGs were black with plain screenshots and 0 of 20 with the override, at the lit panel's size. Side note: |
|
I reviewed 284db40 and found no problems in the code. The new status-bar-ordering test fails on the 8ee29b5 code path, so it covers the regression it targets. The live timing, rotation and fold numbers in your comment are at this head. There are no conflicts. All 25 checks pass. No review threads are open. Nothing else needs to change before merge. |
Summary
On a single-panel iOS simulator, the display-inventory read only supplies
displayRotation. Once a resolved table shows one panel, the read runs besidesimctl io screenshot, with a 2 s budget and a 250 ms grace after the image and the status-bar release, as on Android. A late read is aborted and the rotation is absent, as documented. Multi-panel and unknown devices keep the read first, so a folded Duo names its lit panel (#2703). Only the multi-panel verdict is cached. 11 files; ADR 0025 is amended.Diagnostics: a canceled CoreDevice read logs
probe-canceledat info. A read beside the capture that finds several panels emitsapple_display_single_panel_count_stale.Validation
Live runs used head
284db40716and baseb13b016e9b(main), on the iPhone 18 Pro simulator. Arms were interleaved, n=24 per arm, with a 1-minute load average of 8–20. The table shows the daemon'sdurationMs.--normalize-status-barAt this load the probe alone takes a median of ~120 ms. Every shot carried a rotation.
--normalize-status-bar.pnpm gate layeringpass. CI ownscheck:affected.🤖 Generated with Claude Code