Repository navigation
Conversation
There was a problem hiding this comment.
No issues found across 3 files
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
2f5e561 to
7fbdc88
Compare
|
Apex Sentinel could not review commit Apex Sentinel did not review this pull request, as GitHub will not produce its diff, which is over GitHub's own limits on the number of files or lines in a diff ( |
|
@apex-sentinel-staging review GitHub can now serve the current review diff: 2 files, 1,792 characters. The temporary review base is d353396 (the independently source-reviewed rebase plus the reviewed fixture and lock fixes); source head 7fbdc88 is unchanged. This incremental review covers the remaining comment and explicit-cwd test fixes. The full foundation passed local affected and full checks at that exact head. The full-baseline GitHub workflows retain original event base ea41458. My rapid close/reopen let the closed-PR cancellation workflow cancel those new runs; its log proves the cancellation. I am retrying those cancelled workflows once, without changing the source or their full baseline. Do not merge into the temporary review branch; publication into 0.22 still requires the completed checks and review. |
|
Integrated the exact tested head |
|
This PR is ready: I found no problems in the two-file change at 7fbdc88 (one test file and a doc comment). Not blocking: the shortened doc comment in packages/daemon/src/server/request-execution-scope.ts drops the reason the map is exported (the #2833 reaper shares it), but it still states the sharing purpose, so take it or leave it. This covers the two-file change on top of the review base. Five CI jobs are still queued or in progress and none has failed, so the results are not in yet. There are no conflicts. Before merge, the five pending CI jobs need to pass. |
Summary
Integrated the refreshed foundation into
0.22at7fbdc88730924f7cabeff9b984876c8495aea068with an exact lease on the previous0adf3b48head. All 15 milestone commits are retained on mainea414582; the released remote-script contracts are restored without a protocol bump or waiver. The final repair delta touches six files. Related: #3759, #4591.This PR is closed as integrated by the authorized branch rebase. GitHub rejected changing its temporary review base to
0.22, whose head now equals this PR. No merge was made into the temporary validation branches. #4579 now targets0.22directly and retains its package/live acceptance holds.Validation
Tested head:
7fbdc88730924f7cabeff9b984876c8495aea068.v0.21.38passed; no removals.ea414582.Post-push
0.22checks remain separate. Existing plugin/live acceptance holds and controlled startup measurement remain open.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.