Skip to content

ci: validate the refreshed 0.22 foundation - #4607

Closed
thymikee wants to merge 2 commits into
validation/0.22-review-base-20261116from
fix/0.22-symlink-fixtures
Closed

thymikee wants to merge 2 commits into
validation/0.22-review-base-20261116from
fix/0.22-symlink-fixtures

Conversation

@thymikee

@thymikee thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Integrated the refreshed foundation into 0.22 at 7fbdc88730924f7cabeff9b984876c8495aea068 with an exact lease on the previous 0adf3b48 head. All 15 milestone commits are retained on main ea414582; the released remote-script contracts are restored without a protocol bump or waiver. The final repair delta touches six files. Related: #3759, #4591.

This PR is closed as integrated by the authorized branch rebase. GitHub rejected changing its temporary review base to 0.22, whose head now equals this PR. No merge was made into the temporary validation branches. #4579 now targets 0.22 directly and retains its package/live acceptance holds.

Validation

Tested head: 7fbdc88730924f7cabeff9b984876c8495aea068.

  • Pinned frozen install, build, format and 94 focused regressions passed.
  • Released-wire compatibility against v0.21.38 passed; no removals.
  • Exact affected: 42 passed, 25 skipped. Full: 41 passed, 25 skipped. Both receipts confirm the exact commit and unchanged checkout.
  • Unit: 20,264 passed; provider integration: 299 passed.
  • Hosted: 36 successful checks, ten skipped and one neutral; no failing checks. Full workflow event base remains ea414582.
  • Independent rebase and fixture source reviews found no actionable findings. Sentinel approved the final two-file review view; that view is narrower than the full CI baseline.

Post-push 0.22 checks remain separate. Existing plugin/live acceptance holds and controlled startup measurement remain open.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

@thymikee thymikee added this to the 0.22 - lean core milestone Nov 16, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.33 MB 6.14 MB -188.6 kB
Package (unpacked) 6.33 MB 6.14 MB -188.6 kB
Package (download) 1.92 MB 1.86 MB -56.9 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 42.4 ms 67.5 ms +25.2 ms
CLI --help 83.4 ms 108.6 ms +25.1 ms

@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 0 no longer raised

No open findings.

Reviewed with this repository's own Sentinel configuration (ea414582b7fa).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Earlier reviews

Review of 2f5e5611 · 16.11.2026 17:57 UTC

Apex Sentinel · ✅ Approve

No open findings.

Reviewed with this repository's own Sentinel configuration (cb335952017e).

@thymikee
thymikee force-pushed the fix/0.22-symlink-fixtures branch from 2f5e561 to 7fbdc88 Compare November 16, 2026 18:48
@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel could not review commit 7fbdc887. No review ran, so there are no findings; this is not a verdict on the change.

Apex Sentinel did not review this pull request, as GitHub will not produce its diff, which is over GitHub's own limits on the number of files or lines in a diff (input_limits.pr_max_diff_size allows 300,000 characters). Split it into several pull requests, then push a new commit or comment @apex-sentinel-staging review. @apex-sentinel-staging review force cannot help here: GitHub will not produce a diff to review.

@thymikee thymikee changed the title test: unlink directory symlinks in runner fixtures ci: refresh 0.22 on main and repair fixture cleanup Nov 16, 2026
@thymikee thymikee changed the title ci: refresh 0.22 on main and repair fixture cleanup ci: validate the refreshed 0.22 foundation Nov 16, 2026
@thymikee
thymikee changed the base branch from 0.22 to validation/0.22-main-refresh-20261116 November 16, 2026 19:08
@thymikee thymikee closed this Nov 16, 2026
@thymikee thymikee reopened this Nov 16, 2026
@thymikee
thymikee changed the base branch from validation/0.22-main-refresh-20261116 to validation/0.22-review-base-20261116 November 16, 2026 19:20
@thymikee

Copy link
Copy Markdown
Member Author

@apex-sentinel-staging review

GitHub can now serve the current review diff: 2 files, 1,792 characters. The temporary review base is d353396 (the independently source-reviewed rebase plus the reviewed fixture and lock fixes); source head 7fbdc88 is unchanged. This incremental review covers the remaining comment and explicit-cwd test fixes. The full foundation passed local affected and full checks at that exact head.

The full-baseline GitHub workflows retain original event base ea41458. My rapid close/reopen let the closed-PR cancellation workflow cancel those new runs; its log proves the cancellation. I am retrying those cancelled workflows once, without changing the source or their full baseline. Do not merge into the temporary review branch; publication into 0.22 still requires the completed checks and review.

@thymikee
thymikee added this pull request to stack #4612 November 16, 2026 19:26
@thymikee
thymikee removed this pull request from stack #4612 November 16, 2026 19:51
@thymikee

Copy link
Copy Markdown
Member Author

Integrated the exact tested head 7fbdc88730924f7cabeff9b984876c8495aea068 into 0.22 using an explicit lease on 0adf3b48. The local affected/full gates and full-baseline hosted CI are green. GitHub rejected retargeting this PR to the identical branch head, so this closes the validation PR as integrated. No merge was made into either temporary validation branch. #4579 now targets 0.22 directly and remains held for supported package installation and live App Automate acceptance.

@thymikee thymikee closed this Nov 16, 2026
@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready: I found no problems in the two-file change at 7fbdc88 (one test file and a doc comment). Not blocking: the shortened doc comment in packages/daemon/src/server/request-execution-scope.ts drops the reason the map is exported (the #2833 reaper shares it), but it still states the sharing purpose, so take it or leave it. This covers the two-file change on top of the review base. Five CI jobs are still queued or in progress and none has failed, so the results are not in yet. There are no conflicts. Before merge, the five pending CI jobs need to pass.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant