Repository navigation
Conversation
|
Validation receipt for
The focused transport/proxy/shared-owner/real-daemon set passed167tests on Node26.11.1 and Node22.12.0 (explicit --experimental-strip-types for source tests). The corrected import-boundary focused+closure set passed1,070tests. Real HTTP client→actual proxy→actual daemon cases independently prove interrupted-prefix rollback/resume/finalization and a separately preflighted uninterrupted transfer. Tests observe actual persisted bytes/truncation and final ABCDEF, plus308offset semantics. Nine isolated production counterfactuals fail at intended assertions: remove each of pump/iterator-stop/request-close joins; dispose before owned stop; count drain as byte progress; remove empty-upload or empty-custom-read fairness; extend aggregate; refresh aggregate on a phase change. Every restore matches all11source hashes and passing controls. Three independently held cleanup rows prove settlement/disposal ordering. The drain-only row checks destruction at its original deadline before advancing any rearmed cleanup deadline. Public built-package probes on Node22.12.0, Node26.11.1 and Bun1.4.2 returned the expected body in60HTTP/HTTPS deliveries. Three Bun route comparisons differ without NODE_USE_ENV_PROXY=1: Fetch uses configured proxies and the default Node adapter goes direct. The README discloses this measured migration; parity is not claimed. Opt-in and NO_PROXY=127.0.0.1 were tested. Eight real-loopback callback-lifecycle probes per runtime cover typed phase/aggregate failures, caller reason identity, early401/413 without input cancellation,204and timer disposal. These deliver actual timer callbacks after I/O boundaries; they do not measure30/120/600elapsed seconds. The final rebuilt package's10dist files match hashes before/after these probes. General runtime/environment compatibility is not inferred. Independent source/smaller-design, proof, runtime-disclosure and lazy-boundary reviews report no concrete findings at their recorded snapshots. The final candidate matches the accepted source manifest. Preserved history: earlier controlled-cleanup5000ms failure and weak iterator mutant survival; initial type/setup failures; wrong-base Fallow; corrected complexity/colocation prerequisites; and the exact d3bff gate's eager-closure failure (20,212unitpassed/1failed/10skipped). The latter is fixed by function-scoped transport loading, with no gate waiver. Later receipts do not relabel old failures or prove historical Linux/#4512 causes. No timeout widening, retry, fallback or gate weakening. This is only the proxy layer of #4441. Ingress/ticket lifetimes and source-install/download propagation remain separate. No device run is required for this HTTP-only change. CI remains authoritative; no merge is requested. |
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 11 files
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
|
Review-round validation at Accepted all five Cubic findings. The correction changes only the rollback test and README: standard loopback capability guard before setup; the same two cases via test.for; require a nonempty client error list; qualify preflight response consumption; clarify Bun transfer routing and the separate health limit. Production proxy source is byte-identical to2d85. Claude independently reviewed the exact607b delta and found no new regression. With The exact command |
|
The code at 607b3bb has one change to make before merge. CI is green (19 checks, none failing), and there are no conflicts. The route check in transfer-transport.ts:19 copies the branches of Not blocking, and you can take or leave these: the preflight 204/205/304 null-body repair is a second fix that the transfer bounds do not need, and it re-spells The five inline threads (four on tests and README, one on Bun guidance) all look fixed at this head, so please resolve them: #4613 (comment), #4613 (comment), #4613 (comment), #4613 (comment), #4613 (comment). The 600s aggregate is a policy choice with no recorded decision on #4441, and it newly caps proxied uploads that the client does not bound in total, so please confirm that choice. |
|
Addressed in
The600s policy is unchanged and your confirmation6930427053 is noted. Its authority remains Decision6827686874 items3–4 and proxy Decision6876352959. Claude independently reviewed the production delta without blocking findings. Root corrected its low-severity ledger-byte finding and added the lazy-mock premise. Final focused165/165 pass on both Node22.12.0 and26.11.1, zero skips. All6 isolated routing/loading/precedence mutants are detected and restored; new control5pass, prior production4fail/1pass,49notselected. Real-loopback and earlier runtime receipts retain their original SHA authority. Exact One intermediate6873 focused run failed the existing10ms operator-cap socket test (164passed/1failed). Unchanged607b base passed167 and an instrumented candidate passed165; cause remains unproven. The failed receipt remains preserved and no timing, assertion, worker or gate policy changed. New-head passes do not diagnose it. No merge/release/tag is authorized. |
Keep transfer selection with proxy admission and load transfer mechanics only for transfer routes. Preserve the first classified failure while owned cleanup joins. Keep the independent foreign-preflight null-body repair outside this layer.
Verify transfer mechanics cannot load in the lazy-boundary control and restore the wire ledger byte-for-byte to base after splitting the independent preflight repair.
|
This PR is ready at f7e0be4. The findings from the earlier review at 607b3bb (#4613 (comment)) are fixed, and I found nothing new that blocks the merge. Not blocking: the probe at https://github.com/callstack/agent-device/blob/f7e0be4/packages/proxy/src/daemon-proxy-transfer.test.ts#L370 uses a bare All 19 checks at f7e0be4 pass, and there are no conflicts. The PR body mentions an intermediate operator-cap socket failure with an unproven cause. That is outside this change. All five open inline threads are fixed at this head, so please resolve them: #4613 (comment) (the test file is not touched by this change), #4613 (comment) (README now says preflight bodies are consumed and a timeout returns HTTP 500), #4613 (comment) (README |
Summary
Bound proxy-owned transfer forwarding with the adopted 600-second aggregate and 30/30/120-second phases. Preserve early responses, resume offsets, cancellation, owned cleanup and validated transfer-only error details. Covers 10 files and 2,496 gross lines for the proxy layer of #4441; daemon ingress and source-install remain separate.
Transfer classification now shares the proxy admission owner. RPC, health and diagnostics avoid loading transfer mechanics. A later abort or timer during cleanup cannot replace the first failure. The independent foreign-preflight null-body repair is deferred by Decision6930011679; the wire ledger matches base.
Validation
Head
f7e0be4925b359639f5a9295d4824fb3cb367792, baseea414582b7faa5153f601180057b07c001e1e37d: pinned setup/build, full format, typecheck and wire scan passed; 165 focused tests passed on Node22.12 and26.11. Six isolated mutants discriminated; prior production fails four of five new regression controls. Claude reviewed the production delta; its ledger/premise findings were corrected.Exact
check:affected --run --base ea414582b7faa5153f601180057b07c001e1e37d --head f7e0be4925b359639f5a9295d4824fb3cb367792 --json: 9 passed/7 CI-owned or parked skips, 385 related and20,211 unit passed/10 skipped; exactCommit=true, checkoutChanged=false, failOpen=false. #4050 retained.Earlier real-daemon rollback/normal completion and runtime evidence retain their original heads. One intermediate focused operator-cap socket failure remains cause-unproven; unchanged base passed. Old failures remain preserved. New CI is pending; no merge authorization.