Repository navigation
refactor(client): remove managed daemon lifecycle - #4614
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 35 files
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed) No open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/daemon-client/src/daemon-client-lifecycle.ts:103 |
🆕 Library client replay/test silently lost its private daemon and now needs a shared one |
Reviewed with this repository's own Sentinel configuration (b13b016e9bc1).
Review of d4c99975 · 16.11.2026 20:38 UTC
Apex Sentinel · ✅ Approve
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/daemon-client/src/__tests__/daemon-client-startup-race.test.ts:644 |
Startup-race row no longer asserts how many RPCs the winner received |
Reviewed with this repository's own Sentinel configuration (ea414582b7fa).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on d4c9997. The verdict and the full list are in the summary comment.
|
I found no new blocking problems in the code at d4c9997, but the open review threads below still need fixes before this can merge. All 17 checks pass at this head, and there are no conflicts. Not blocking, and you can take or leave these: (1) The migration note in client-api.md:95 tells every managed client to call These open threads still apply: example error handling, eve.md idle exit, test-local sendToDaemon wrapper, migration note stateDir, and stale teardown wording. For the last one, the stale side is Please fix these threads first: put |
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on a882478. The verdict and the full list are in the summary comment.
Summary
For #3759 section 2, library clients attach to an existing daemon and no longer start, replace or retire it after timeouts. Remove
daemonLifecycle: 'managed'and start the daemon explicitly:This includes
client.replay.run()andclient.replay.test(). UsestartAgentDevice({ stateDir })to own an in-process daemon. CLI/MCP ensuring and their private one-shot replay/test startup and cleanup remain supported.Scope: 35 files, including migration docs, examples, regressions and a changeset. Remote health-recovery budgets and cancellation are preserved. Review fixes cover explicit startup, state-directory migration, cancellation-context identity and RPC race coverage. The final three-file documentation correction clarifies library replay startup and cancellation.
Validation
Head:
3a1ff5fa4ddef9e26553be6a99fe5c2133293f1d.check:affected --run --head <SHA>: 42 passed, 25 skipped;exactCommit=true,checkoutChanged=false.a882478, fullpnpm checkpassed 41 checks with 25 skipped, wire compatibility againstv0.21.38passed, and all 16 hosted checks were nonfailing.d4c9997and28e37effound no actionable regressions. The final documentation delta was cold-read against 0.22: remove superseded plugin, client and environment APIs #3759; runtime tests and another full gate were unnecessary for that delta.Hosted checks at the new head remain required. No new live-device result or merge clearance is claimed.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.