Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 9 files
You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/plugins/src/store.ts:399 |
add-artifact refuses hosts where HOME is unset but homedir() resolves |
2 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (ea414582b7fa).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 356a669. The verdict and the full list are in the summary comment.
|
I found no blocking problem in the code at 356a669. All 17 checks pass at this commit and there are no conflicts. The containment claim rests on npm's extractor, the realpath checks at store.ts:437-449, and Not blocking, and you can take or leave these: Before merge, please answer or fix the open inline threads. The most useful ones are the host plumbing at plugins.ts:27 (#4615 (comment)) and the positional label at command-overrides.ts:23 (#4615 (comment)). The other threads that still apply are the Windows npm call in tests (#4615 (comment)), the unchecked-compatibility text output (#4615 (comment)), the prerelease leading zeros (#4615 (comment)), and the missing-HOME refusal (#4615 (comment)). The thread about documenting the replacement steps does not apply, so you can resolve it: website/docs/docs/plugins.md already documents them, and the CLI refuses with typed reasons (#4615 (comment)). |
|
Thanks for the update. At 47b4d14 the code looks right to me, but the Coverage check is red on this head and it passed at 356a669, so the new failure came with this change. The failing route overlaps your delta: From the earlier review: the Could The open inline threads from #r4591300984, #r4591300998, #r4591301004, #r4591301012, #r4591301043, #r4591301051 and #r4591349998 are fixed at this head. Please resolve them. There are no conflicts. Before merge, please answer the shared-transaction question and get Coverage green or explained. |
|
This PR is ready from the code side at 4d0b010. The earlier review at 47b4d14 (#4615 (comment)) asked for evidence, and that evidence is now in place. Not blocking: the fix in src/core/interactors/limrun-ios-runner.fixtures.ts (https://github.com/callstack/agent-device/blob/4d0b010/src/core/interactors/limrun-ios-runner.fixtures.ts#L18) for the aborted-upload rejection is unrelated to the plugin manager, so would you consider moving it into its own small PR? Keeping it here is fine, since it is test-only and unblocks Coverage. All seven earlier inline threads are addressed at this head, so you can resolve them. The six marked fixed are: the Windows npm exit-code check in store-artifact.test.ts (#4615 (comment)), the "unchecked" compatibility report in plugins.ts (#4615 (comment)), consistent host.env use in plugins.ts (#4615 (comment)), the leading-zero prerelease check in isExactVersion (#4615 (comment)), the Smoke Tests failed in smoke:keyboard-ime, where There are no conflicts. Before merge, please rerun the Android smoke job. Please also answer the open question from the 47b4d14 review: should changePlugin and addPluginArtifact (store.ts:342 and store.ts:394) share one store-transaction owner? This update does not address it. |
Summary
Install a local plugin archive through the existing manager for #4591 and #4597.
The manager verifies staged archive integrity before selection and records its installation ID, exact version and SHA-512 digest. Installation skips lifecycle scripts and factory loading; listing checks compatibility. The add receipt marks compatibility unchecked. Existing selections cannot be silently replaced or updated from the registry. Restart the daemon after changing selections. CLI operations use the supplied host environment and working directory.
Scope: 12 files; CLI, public manager API, tests, docs and changeset. No new package or publication change.
Validation
Tested head:
4d0b0108c3a7fc66f404031474582bf8f1224712.exactCommit=trueandcheckoutChanged=false.47b4d14exposed an unhandled aborted fixture upload. A real interrupted-upload regression reproduced the error before the fixture fix and passed afterward; the owning test file passed 41 tests.b719e5dfound one test assertion issue, corrected subsequently. The small fixture follow-up was cold-read; no fresh independent review at this head.Hosted checks, T3/e2e adoption and live provider acceptance remain separate.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.