Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 12 files
You’re at about 99% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/host-kit/src/internal/exec.ts:264 |
Output-limit breach throws even for callers that pass allowFailure: true |
Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).
Review of 372a542f · 17.11.2026 07:17 UTC
Apex Sentinel · ✅ Approve
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/host-kit/src/internal/exec.ts:264 |
Output-limit breach throws even for callers that pass allowFailure: true |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 372a542. The verdict and the full list are in the summary comment.
|
This PR is ready at 34b1daa. The code looks correct, and all 14 checks pass at that commit. There are no conflicts. The default path (maxBuffer omitted) is covered by the real-subprocess tests in exec.test.ts, so no device run is needed. Nothing blocks merge except order: the PR targets the stacked base fix/a1-extraction-unused-import-20261116, so it merges after that layer. Not blocking, and you can take or leave these: (1) the precedence abort > timeout > output_limit lives in both commandSettlementReason and the guard in settle, so branching settle on the final reason would give the ladder one owner; (2) commandSettlementReason and normalizeTimeoutMs are not tracing code and only exec.ts uses them, so they fit better in exec.ts or an exec-settlement module, unless a size gate forced the move; (3) bindCommandLifecycle now sits between the CommandKillSettlement doc block and its type, and execResult lost its doc line; (4) validation-case.ts re-exports encodeValidationCase, so validation-arbitraries-cli.ts has two spellings of one symbol, and it would be cleaner to import from @agent-device/test-kit and drop the re-export; (5) CASE_GENERATION_INPUTS lists the test-kit barrel, which changes for unrelated helpers, so listing only the two generator files is enough; (6) provider-webdriver.ts is the only production caller that passes maxBuffer (10 MiB), so cloud WebDriver host commands above that now fail with command_output_limit, which is worth naming in the PR body, and runCmdSync could map ENOBUFS to the same details. On the other review threads: the threads on background maxBuffer, retry block, runScript waiver and coversCommand matching are fixed at this head, so they can be resolved. The allowFailure thread does not apply: allowFailure covers non-zero exits only, timeouts and sync buffer overflow already throw regardless, and an output-limit breach is a resource violation, so throwing is consistent. |
|
Reviewed the six optional notes against
The output-limit error now retains bounded captured prefixes. The five tracked review threads are resolved. New-head hosted checks and parent-layer acceptance remain separate from the prior |
|
I reviewed 00e8e05 against the earlier review at 34b1daa (#4621 (comment)). I found no new problems in the delta. The output limit error now carries the bounded stdout and stderr prefixes, and the trace reports |
|
Re the output-size question in #4621 (comment): CLI and daemon wire errors pass through |
00e8e05 to
472f2c2
Compare
Summary
Bound captured host-command output by raw bytes per stream while preserving timeout, cancellation and decoding behavior. Cloud WebDriver host commands use a 10 MiB per-stream cap; exceeding it rejects with
command_output_limit. Output-limit errors retain already-captured stdout and stderr, including when allowFailure is set. Move fuzz support to test-kit and keep fixed-seed Maestro completeness beside the parser. The 12-file prerequisite supports #4617 and targets #4579.Validation
At
472f2c2ded1c0994131f77e420d87b5e8fa595b6, local exact-head affected passed (42 passed, 25 skipped; unchanged checkout). Real-process prefix regression passed for both streams; an isolated parent experiment failed on missing details. The nine prerequisite patches are unchanged by range-diff onto #4579 atdfa349fd5d8dbdf89b22a9ef53c9e0bb149f3db1. Prior bounded source reviews and coordinator follow-ups covered executor and fuzz ownership; the diagnostic fields received a coordinator cold review. Hosted checks completed without failures: 13 successful, one skipped and one neutral. Sentinel reports no findings; all five review threads are resolved. Land #4579 first. Its new review fixes and the dependent restack remain pending; no merge clearance.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.