Skip to content

fix(remote): deliver batch recordings through one request receipt - #4627

Draft
thymikee wants to merge 7 commits into
mainfrom
t3/batch-delivery-receipts
Draft

thymikee wants to merge 7 commits into
mainfrom
t3/batch-delivery-receipts

Conversation

@thymikee

@thymikee thymikee commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

A remote recording can finish inside batch. The daemon reports one receipt for completed script writes and closes; the client validates its recording scope and submitted plan, downloads one version, and retires a validated close even if delivery fails. Original batch errors and delivery warnings are preserved, including when the client record is gone.

Closes #4595. 29 files, including ADR/user-guide updates and a verbatim split of the runtime package-boundary test to clear an upstream 1,001-line lint failure. No assertions or limits changed.

RPC protocol 3 rejects receipt-unaware protocol-2 peers before dispatch; upgrade both peers together. Nested batch/replay admission and destination policy stay unchanged.

agent-device open Settings --save-script ./journey.ad
agent-device batch --steps '[{"command":"wait","input":{"selector":"label=\"Apps\""}},{"command":"close","input":{}}]'

Validation

Head d222cd6e623b3907559d62eb7c525cc111a55a52, rebased onto fce2fa6247. Range-diff preserves all six feature commits unchanged.

  • Focused lint and all 16 boundary tests pass after the split; moved test body is byte-identical.
  • Prior af2fdd5 on base e0ab0c255c: exact affected gate 42 passed, unit 20,279 passed / 10 skipped, provider 301 passed; receipt run-NiNBgJ.
  • Rebased affected gate run-Jgae6B could not acquire another live owner's lock; only our waiter was cancelled. This is unvalidated at the full-gate level.
  • Receipt and protocol regressions have isolated before/after failure proof. Experiments removed.

Draft pending current-head CI, full validation and required independent design review. Native/device lanes remain unverified locally.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.35 MB 6.36 MB +5.1 kB
Package (unpacked) 6.35 MB 6.36 MB +5.1 kB
Package (download) 1.93 MB 1.93 MB +1.4 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 25.6 ms 21.9 ms -3.7 ms
CLI --help 51.7 ms 64.1 ms +12.4 ms

@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 0 no longer raised

No open findings.

2 findings below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (fce2fa6247c5).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Earlier reviews

Review of af2fdd57 · 17.11.2026 11:12 UTC

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed)

No open findings.

2 new findings away from what changed since f029c66 not shown. Comment @apex-sentinel-staging review for a full review.

Reviewed with this repository's own Sentinel configuration (fce2fa6247c5).

Review of f029c66c · 17.11.2026 10:40 UTC

Apex Sentinel · ✅ Approve

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
packages/remote/src/session-script-destination.ts:114 Receipt failures are not disclosed when the client's record is gone

2 findings below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on f029c66. The verdict and the full list are in the summary comment.

@thymikee
thymikee force-pushed the t3/batch-delivery-receipts branch from af2fdd5 to d222cd6 Compare November 17, 2026 11:20
@thymikee

Copy link
Copy Markdown
Member Author

CI lint failed on the synthetic merge with newer main: its new capture-kit export pushed package-boundaries.test.ts to 1,001 lines. Rebased at d222cd6 and moved the runtime Node-resolution case verbatim into package-boundaries-runtime.test.ts. All 16 checks and focused lint pass; every assertion and the 1,000-line limit are retained. Range-diff shows all six feature commits unchanged.

The new full affected gate is blocked by another live validation owner (run-Jgae6B); I cancelled only our waiter. The draft stays pending current-head CI and the independent design review. The previous af2fdd5 exact gate passed all 42 runnable checks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote script recordings: deliver batch step scripts through one daemon-side delivery receipt

1 participant