Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. 2 findings below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/remote/src/session-script-destination.ts:114 |
Receipt failures are not disclosed when the client's record is gone |
2 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (e0ab0c255c3d).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on f029c66. The verdict and the full list are in the summary comment.
af2fdd5 to
d222cd6
Compare
|
CI lint failed on the synthetic merge with newer main: its new capture-kit export pushed package-boundaries.test.ts to 1,001 lines. Rebased at d222cd6 and moved the runtime Node-resolution case verbatim into package-boundaries-runtime.test.ts. All 16 checks and focused lint pass; every assertion and the 1,000-line limit are retained. Range-diff shows all six feature commits unchanged. The new full affected gate is blocked by another live validation owner (run-Jgae6B); I cancelled only our waiter. The draft stays pending current-head CI and the independent design review. The previous af2fdd5 exact gate passed all 42 runnable checks. |
Summary
A remote recording can finish inside
batch. The daemon reports one receipt for completed script writes and closes; the client validates its recording scope and submitted plan, downloads one version, and retires a validated close even if delivery fails. Original batch errors and delivery warnings are preserved, including when the client record is gone.Closes #4595. 29 files, including ADR/user-guide updates and a verbatim split of the runtime package-boundary test to clear an upstream 1,001-line lint failure. No assertions or limits changed.
RPC protocol 3 rejects receipt-unaware protocol-2 peers before dispatch; upgrade both peers together. Nested batch/replay admission and destination policy stay unchanged.
agent-device open Settings --save-script ./journey.ad agent-device batch --steps '[{"command":"wait","input":{"selector":"label=\"Apps\""}},{"command":"close","input":{}}]'Validation
Head
d222cd6e623b3907559d62eb7c525cc111a55a52, rebased ontofce2fa6247. Range-diff preserves all six feature commits unchanged.af2fdd5on basee0ab0c255c: exact affected gate 42 passed, unit 20,279 passed / 10 skipped, provider 301 passed; receiptrun-NiNBgJ.run-Jgae6Bcould not acquire another live owner's lock; only our waiter was cancelled. This is unvalidated at the full-gate level.Draft pending current-head CI, full validation and required independent design review. Native/device lanes remain unverified locally.