Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveNo open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
|
This PR is ready at b88e4e1: it only moves the two transfer-module loading cases into an isolated proxy test file, with the same cases and assertions, and there are no conflicts. The Lint, Typecheck & Package failure is main's max-lines breakage in scripts/layering/package-boundaries.test.ts (1001 lines, also red on main at fce2fa6), which this diff does not touch; #4630 fixes it, and a rebase or re-run after that should go green. It is still a draft, so please mark it ready for review when you want it labeled. |
Summary
Move the two transfer-module loading cases into an isolated test file. Change 2 files. Keep all 21 cases, the 10 ms operator cap, and all response assertions. Scope remains proxy tests.
The failure is test isolation. During the failed timeout case,
proxyErrorResponseimported the preceding test's throwing Vitest mock. The listener receivedtransfer mechanics loadedand destroyed the socket. Production code does not change.Closes #4629.
Validation
Tested head:
b88e4e182bb2de7ba8fbdd8115ae127cc156bc3f.Base:
fce2fa6247c5287cfabaaeeabfda9ab946f881ff.pnpm exec vitest run --project unit-core packages/proxy/src/daemon-proxy-transfer.test.ts --coveragereproducedsocket hang upon base, run 2. Focused coverage used no reporter and zero global coverage thresholds.pnpm formatpassed.pnpm check:affected --run --head b88e4e182bb2de7ba8fbdd8115ae127cc156bc3ffailed withexactCommit: true. Format passed. Lint failed:scripts/layering/package-boundaries.test.ts:1001:4,eslint(max-lines), 1001 lines, limit 1000. Fresh unchanged-basepnpm lintfailed identically. Remaining selected checks did not run. Owner: layering package-boundary tests. This draft is base-blocked.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.