Repository navigation
fix(checkbox)!: align state layer, touch target and focus ring with Material 3 #5104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Doberjohn
merged 34 commits into
callstack:main
from
likevy:feat/fix-residual-md3-deviation-checkbox
Nov 6, 2026
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
1a774eb
fix: paint the MD3 state layer on checkbox
likevy 1ddbd87
fix: ripple the checkbox press inside the state layer
likevy 6ebdc86
fix: meet the 48dp touch target on checkbox
likevy 1f0e89c
fix: offset the checkbox focus ring by 2dp
likevy 37ab78a
feat: add tapTargetStyle to the checkbox
likevy d7205a3
feat: require an accessible name on a standalone checkbox
likevy 314cb5e
test(checkbox): adapt tests after rebase onto main
likevy c060f2e
fix(checkbox): skip the accessible name warning for hidden checkboxes
likevy a5c403e
refactor(checkbox): drop the tapTargetStyle prop
likevy 8fb45fe
refactor(checkbox): remove internal test IDs
likevy 05ae4ce
chore(example): name the example checkboxes
likevy d9ba88d
fix(checkbox): toggle on space key on web
likevy 64590ec
fix(checkbox): size the outer container to the touch target
likevy 17d078b
fix(checkbox): judge the accessible name by what the platform supports
likevy ec21e74
fix(checkbox): press in and out on space like enter
likevy df3fe38
test(checkbox): cover a row disabled in the middle of a space press
likevy cfa49af
refactor(checkbox): rename the checkbox state layer resolver
likevy afb4c40
docs(checkbox): describe the checkbox changes against 5.x
likevy 71c7a4d
docs(checkbox): name the checkbox in the usage example
likevy b6de531
fix(checkbox): press out when a space press loses onPress
likevy 3797c68
test(checkbox): cover the hiding props on the platforms that ignore them
likevy c79fe23
fix(checkbox): warn about a missing accessible name only in development
likevy 6ef4781
fix(checkbox): keep checkbox item rows 56dp tall
likevy 798dcfb
fix(checkbox): always paint the checkbox press
likevy ae9c5bf
fix(checkbox): report layout from the outer container
likevy 88819ec
fix(checkbox): leave a space release without a pending press alone
likevy 5327331
test(checkbox): re-enable the checkbox before the space release
likevy 108a034
docs(checkbox): cover space toggling and hidden checkboxes
likevy a65bb0a
test(checkbox): render the android ripple in the ripple props test
likevy 331f611
docs(checkbox): describe the space release left alone
likevy df79efa
Merge branch 'main' into feat/fix-residual-md3-deviation-checkbox
Doberjohn b3bc1a1
fix(checkbox): type the space key handlers with react native key events
likevy 0138c5b
fix(checkbox): drop the dependency array from the ripple reaction
likevy fe36674
fix(checkbox): type key events for legacy React Native types
likevy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.