Repository navigation
fix!: expand interactive targets to the 48dp minimum #5108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
27ee271
fix: expand interactive targets to the 48dp minimum
lukemorawski 1c70fde
fix: hitslop and styling
lukemorawski aab7ec7
test: update snapshots after rebasing onto main
k0ndee 5e8645a
fix: compute per-component hit slops
k0ndee eee19e9
fix: keep Chip JSDoc attached to component declaration
k0ndee 3a99241
test: pass explicit testID after removal of hardcoded defaults
k0ndee ffc991f
fix: address review feedback on 48dp touch targets
k0ndee 2985c8a
test: fix tests broken by rebase onto upstream main
k0ndee d3671d7
refactor: trim redundant comments and simplify TouchableRippleWeb tests
k0ndee d6eba47
chore: rework hitSlop tests and trim stale comments
k0ndee 898490c
refactor: drop hitSlop from Checkbox, Switch and RadioButton
k0ndee 02e157f
fix: address review feedback on 48dp touch targets
k0ndee 4f42726
Merge branch 'main' into @k0ndee/48dp-touch-targets
xdimota7x 296ac11
test: close the hitSlop tests in TouchableRipple.test.tsx after mergi…
xdimota7x 3d08150
fix: address review feedback on 48dp touch targets
xdimota7x 92b4de2
fix(text-input): give the leading icon its full touch target
Doberjohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| /** | ||
| * MD3 Chip spec dimensions. | ||
| * @see https://m3.material.io/components/chips/specs | ||
| */ | ||
| export const ChipTokens = { | ||
| containerHeight: 32, | ||
| } as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.