Repository navigation
fix(menu): trap screen readers and move focus on open/close - #5220
Open
zacyungblut wants to merge 1 commit into
Open
zacyungblut wants to merge 1 commit into
zacyungblut wants to merge 1 commit into
Conversation
|
Found potential problems with the pull request:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5215.
When a
Menuopens, TalkBack on Android keeps reading the page behind it: the menu renders through a plain<Portal>, so nothing hides the background from assistive technology, and the items only appear at the very end of the reading order. Focus also stays on the anchor, sincefocusFirstDOMNodeonly does anything on web.Changes
modal={visible}to the menu'sPortal, the same mechanismModaluses, so the page behind the open menu is hidden from screen readers and focus order on Android.focusFirstDOMNodewith a cross-platformfocusFirstNode: the web behavior is unchanged, and on native it callsAccessibilityInfo.setAccessibilityFocuson the menu when it opens and on the anchor when it closes, matching the focus handoff web already has.Test plan
Menutests pass (no behavior changes on the paths they cover).findNodeHandleis guarded, the web branch is untouched, and thePortalmodalprop mirrorsModal's own usage.Menu.Itemrather than the menu container.