Repository navigation
Conversation
|
Found potential problems with the pull request:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextInputno longer swapsstartAccessoryandendAccessoryby hand in RTL. The row already mirrors through flex direction, so the swap flipped the accessories back to the wrong side.startAccessoryis always the leading slot andendAccessoryis always the trailing slot.hasAccessorynow depends only onstartAccessory.endinstead ofleft, and withstartotherwise.leadingAccessoryRTLandtrailingAccessoryRTLstyles.rightand the counterleft.textAlign: 'left'and the counter keepsright. React Native mirrors these under RTL.Motivation
In RTL layouts the
TextInputlabel, helper text, counter and accessories were placed on the wrong side. Some were mirrored twice, and some used physicalleft/rightvalues. This change places them on the correct side on native and web.Related issue
TextInput: in RTL, startAccessory and endAccessory render on the wrong sides, and on web the label overlaps the start accessory #5214
Screenshots / Videos
Test plan
I18nManager.forceRTL(true)on native, (you can use development builds and toggle a change in a menu drawer) anddir="rtl"on web.flatandoutlinedmodes.startAccessoryis on the right and theendAccessoryis on the left.