Repository navigation
Conversation
|
Found potential problems with the pull request:
|
14 of 47 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Takes over #5143 from @roksanaz, rebased on current
main, with the review comments addressed.Brings
List.ItemandList.Accordionin line with the latest MD3 list spec:leadingandtrailingslots onList.Item, which take precedence overleftandrightChanges since #5143:
overflow: hidden, so rows below move with it. The content stays mounted until collapse finishes. The chevron uses a CSS transition.leadingortrailingslot are not indented.List.Imageaccepts atestID.List.ItemandList.Accordionuse an inward focus ring, like other full-width rows.Related issue
Closes #4976
Part of #4930
Screenshots / Videos
List.Accordion
List.Item screenshots are in #5143.
Video:
list-accordion.mp4
Test plan
Open the List example and:
leadingandtrailingslots render and pick up the item color, including in a selected row.