You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: resume stdin when setting up dev server interactions - #1525
If process.stdin was paused before the dev server starts (for example a CLI prompt calls unpipe() on close), Ctrl+C and the r / d / j / a shortcuts do nothing. setupInteractions enters raw mode, which clears the TTY's ISIG flag, so Ctrl+C is only delivered as stream data. A paused stream delivers nothing, so the keypress listener and the SIGINT handler are never reached.
This adds process.stdin.resume() right after process.stdin.setRawMode(true) in packages/repack/src/commands/common/setupInteractions.ts.
Testing:
Added a test in setupInteractions.test.ts that expects stdin.resume to be called once when interactions are set up. It fails without the change and passes with it.
The whole setupInteractions.test.ts file passes (11 tests).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1515
If
process.stdinwas paused before the dev server starts (for example a CLI prompt callsunpipe()on close), Ctrl+C and ther/d/j/ashortcuts do nothing.setupInteractionsenters raw mode, which clears the TTY's ISIG flag, so Ctrl+C is only delivered as stream data. A paused stream delivers nothing, so the keypress listener and the SIGINT handler are never reached.This adds
process.stdin.resume()right afterprocess.stdin.setRawMode(true)inpackages/repack/src/commands/common/setupInteractions.ts.Testing:
setupInteractions.test.tsthat expectsstdin.resumeto be called once when interactions are set up. It fails without the change and passes with it.setupInteractions.test.tsfile passes (11 tests).