Repository navigation
fix(tools): strip trailing dots in spinner messages without a regex - #745
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
hurali97
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL alert #5 (
js/polynomial-redos, high) inpackages/tools/src/lib/prompts.ts. It has been open onmainsince March.formatStartMessagestripped trailing dots withtext.replace(/\.+$/, ''). On a string with a long run of dots followed by something else, the regex engine retries\.+from every position, so the time grows quadratically: about 3 s for 100k dots and 13 s for 200k. The input is a spinner message, so this isn't exploitable in practice. But the alert fails the CodeQL check on any PR that touches a line in its data flow. For example, #744 fails only because it changes thepackageAarsignature, where CodeQL says the regex's input comes from.This PR replaces the regex with a loop that walks back over trailing dots. The output is unchanged for every input.
Test plan
prompts.test.ts: covers no dots, one dot, three dots, a dot mid-string, only dots, an empty string andundefined, plus a 200k-dot regression case. Against the old regex, the regression case takes 13.5 s and fails the 5 s timeout; with the fix all 8 tests pass in about 1 ms.tsc -p packages/tools/tsconfig.lib.jsonare clean.