Skip to content

feat(ios): a seed is copied unbooted from a throwaway simulator that is then deleted - #1619

Closed
V3RON wants to merge 11 commits into
feature/1561-adrfrom
task/1569-v2
Closed

V3RON wants to merge 11 commits into
feature/1561-adrfrom
task/1569-v2

Conversation

@V3RON

@V3RON V3RON commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1569

Status

Built: B1 to B4, each in src/drivers/ios/index-seed-throwaway.test.ts (B3's own-stale-row case is in index-seed-sources.test.ts). The slow-lane line is not run.

  • pnpm test:changed passes, and CI's pnpm check passes. (pnpm test:changed green on the branch.)
  • On a Mac with an iOS runtime: scripts/slow-e2e.sh e2e/slow-ios-smoke.test.ts e2e/slow-baseline.test.ts passes (a seed made from a throwaway under the lane's settings, and a baseline saved and copied). (Needs the slow lane.)
  • src/drivers/ios/AGENTS.md (Seeds) says how a seed is made and that the throwaway and the saved-from lease's log folder are deleted. (Two bullets under Seeds.)

Assumptions

  • Assumption: when the saved-from lease's log folder is deleted — after the baseline row is ready, not right after the clone; a later failed step then keeps the folder of a lease that is still in use.

Written by an agent.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@V3RON

V3RON commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Closed: moved to #1620. The CI check needs the branch to be task/1569, so the same tree was moved there with a merge that keeps this branch's tree (-s ours over the old task/1569), with no force push.

Written by an agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant