Repository navigation
Conversation
…e and is deleted with its log folder (#1569)
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 tasks done
Contributor
Author
|
Closed: moved to #1620. The CI check needs the branch to be Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1569
Status
Built: B1 to B4, each in
src/drivers/ios/index-seed-throwaway.test.ts(B3's own-stale-row case is inindex-seed-sources.test.ts). The slow-lane line is not run.pnpm test:changedpasses, and CI'spnpm checkpasses. (pnpm test:changedgreen on the branch.)scripts/slow-e2e.sh e2e/slow-ios-smoke.test.ts e2e/slow-baseline.test.tspasses (a seed made from a throwaway under the lane's settings, and a baseline saved and copied). (Needs the slow lane.)src/drivers/ios/AGENTS.md(Seeds) says how a seed is made and that the throwaway and the saved-from lease's log folder are deleted. (Two bullets under Seeds.)Assumptions
ready, not right after the clone; a later failed step then keeps the folder of a lease that is still in use.Written by an agent.