Repository navigation
feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false - #1623
Draft
V3RON wants to merge 23 commits into
Draft
feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false#1623V3RON wants to merge 23 commits into
V3RON wants to merge 23 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
… idle-delete comment (#1598)
Contributor
Author
Review ledgerRound 1: ab4578b {"findings":[{"id":"R1","role":"code","class":"testing 10 title promises unproven other-platform grant","outcome":"fixed","path":"src/daemon/dispatcher-virtual-devices-off.test.ts","round":"1","fix":"2638b4546acc8f3f2cfdcd856a80bd9cdda817c6"},{"id":"R2","role":"claims","class":"comment false: failed destroy leaves shutdown","outcome":"fixed","path":"src/core/create-core.ts","round":"1","fix":"2638b4546acc8f3f2cfdcd856a80bd9cdda817c6"}]}Written by an agent. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1598
Status
Implement: done (9/9 green) Review: round 2 passed (R1, R2 fixed) Hardware: n/a Gate: waiting for the stack
Next: CI on the head; then ready, in stack #1592 → #1623
pnpm test:changedpasses, with every Tests line above as a test. B1config-platform-and-driver-settings.test.ts; B2, B3, B6 (catalog.get) and B7dispatcher-virtual-devices-off.test.ts; B6 (CLI)index-catalog-components.test.ts; B5create-leasing-virtual-devices-off-startup.test.ts; B4create-leasing-warm-pool-virtual-devices-off.test.ts; B10doctor-warm-pool-targets.test.ts.pnpm checkpasses, the protocol-bump check included: protocolmaxis 92 (src/contract/protocol.ts); the pre-push hooks passed.check-openapi: 45 operations, 12 tags: ok.docs/internal/EVENTS.mdandreference/events.mdxlistvirtual-devices-offas an initiator ofdevice.shutdownanddevice.deleted.Assumptions
DoctorConfigis narrowed withPickto the twovirtualDevicesflags it reads, the smallest change.reserveOnVirtualPlatforms, not inside the policy view, so the policy stays pure.catalog.getthrough the dispatcher and the CLI print through the CLI test, because the Tests line names both.Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 2. Tokens: 6.1M.
Runs: 10. Cost USD: 8.0086. Agent seconds: 2373.
Assessment: complete
Written by an agent.