Skip to content

feat(console): offer proxy SSO sign-in alongside operator tokens - #1632

Draft
bheemreddy-samsara wants to merge 1 commit into
callstackincubator:mainfrom
bheemreddy-samsara:bheemreddy-samsara/console-sso-sign-in
Draft

bheemreddy-samsara wants to merge 1 commit into
callstackincubator:mainfrom
bheemreddy-samsara:bheemreddy-samsara/console-sso-sign-in

Conversation

@bheemreddy-samsara

Copy link
Copy Markdown

Summary

A console behind an optional sign-in proxy currently offers only an operator-token form when no proxy session exists. Add http.proxyAuth.signInUrl so operators can start their proxy login from a Sign in with SSO link in the same tab. The token form remains available.

The daemon includes the configured URL in HTTP 401 authentication responses. The console validates the URL scheme before displaying the link. Existing proxies that redirect unsigned requests automatically need no configuration change.

Access policy stays with the proxy or identity provider. This change does not implement OAuth, grant anonymous access, or change operator permissions. The optional configuration field bumps the protocol maximum from 91 to 92 while retaining the existing minimum.

Validation

Head: 690594050793fa186ed97ec45d2b41e1a9c12eb2.

  • pnpm test:changed: 452 files passed; 7,218 tests passed and two existing tests skipped.
  • Final config, HTTP proxy-auth, identity-check and sign-in DOM tests: 64 passed.
  • pnpm test:console --project=chromium e2e/console/sign-in.spec.ts: six passed, including same-tab navigation to a stub proxy login using a real gateway daemon.
  • Repository pre-commit checks passed: formatting, lint, dependency boundaries, test/comment checks, and typecheck.
  • Repository pre-push checks passed: Fallow, protocol bump, documentation surfaces, and E2E typecheck.
  • Website build and OpenAPI check passed: 92 pages and 45 operations.
  • The config and DOM tests failed on the missing behavior before implementation.
  • The browser test stubs the proxy login destination. A deployed identity-provider login is outside this upstream change.

Workflow

flowchart LR
  A[Console without proxy session] --> B[Identity check returns configured login URL]
  B --> C[Sign in with SSO]
  C --> D[Existing proxy login in same tab]
  D --> E[Proxy supplies signed identity]
  E --> F[Existing operator console]
  A --> G[Operator token form]
Loading

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant