Skip to content

Add set no-cd and align path resolution#2981

Open
hans-d wants to merge 1 commit intocasey:masterfrom
hans-d:feat/setting-no-cd
Open

Add set no-cd and align path resolution#2981
hans-d wants to merge 1 commit intocasey:masterfrom
hans-d:feat/setting-no-cd

Conversation

@hans-d
Copy link
Copy Markdown

@hans-d hans-d commented Dec 3, 2025

Summary

Feature: Add module-local set no-cd to skip automatic cd before recipes/backticks; mutually exclusive with set working-directory; recipe attributes still override.

Opt-in behavior: Add set no-cd-strict so when no-cd is on, backticks/shell/path helpers resolve relative to the invocation directory instead of the module dir. Default remains the old behavior for compatibility.

@hans-d hans-d marked this pull request as draft December 3, 2025 10:03
@hans-d hans-d force-pushed the feat/setting-no-cd branch from 6621758 to 1a911bb Compare December 3, 2025 10:30
@hans-d hans-d marked this pull request as ready for review December 3, 2025 11:09
@hans-d hans-d force-pushed the feat/setting-no-cd branch from 1a911bb to 6423262 Compare January 1, 2026 22:57
Copy link
Copy Markdown
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This mostly looks good, but I would remove set no-cd-strict from this PR and leave it for later, to make it simpler.

@elijahfhopp
Copy link
Copy Markdown

Would love to see this make it in. @hans-d I can offer a patch to resolve the changes Casey needs on this PR if you'd like.

To clarify about removing no-cd-strict, we want to have it on or off (while removing the setting)? Just trying to understand the desired behaviour.

Thanks, all!

@hans-d hans-d force-pushed the feat/setting-no-cd branch from 6423262 to 3bcfbbf Compare April 16, 2026 21:35
@hans-d
Copy link
Copy Markdown
Author

hans-d commented Apr 16, 2026

this update is bringing the pr up to match master, and to have all test run locally.

re the no-cd-strict, it's similar to the no-cd but applied more strictly for certain functions (see linked issues). Added as it's new/changed behaviour compared to the original of no-cd.

will spilt the no-cd-strict into a new pr.

@hans-d hans-d force-pushed the feat/setting-no-cd branch from 3bcfbbf to 35b9e86 Compare April 16, 2026 21:55
@hans-d hans-d requested a review from casey April 18, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants