[MT-4732]: Emit ContentSteering as last child of MPD element#21
Merged
Conversation
…O/IEC 23009-1 Amd 1 DASH-MPD.xsd requires ContentSteering to be the final child of the MPD element, after Period, Metrics, EssentialProperty, SupplementalProperty, UTCTiming, and LeapSecondInformation. Strict XSD validators reject manifests that emit it earlier (lenient players such as dash.js and Shaka tolerate it, masking the bug). Move the ContentSteering struct field to follow UTCTiming so encoded output matches the schema. Add a regression test asserting that the encoded byte offset of <ContentSteering follows </Period> and <UTCTiming. Refs MT-4732.
robomac
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix: Emit ContentSteering as last child of MPD per ISO/IEC 23009-1
DASH-MPD.xsd requires ContentSteering to be the final child of the MPD element, after Period, Metrics, EssentialProperty, SupplementalProperty, UTCTiming, and LeapSecondInformation. Strict XSD validators reject manifests that emit it earlier (lenient players such as dash.js and Shaka tolerate it, masking the bug).
Move the ContentSteering struct field to follow UTCTiming so encoded output matches the schema. Add a regression test asserting that the encoded byte offset of <ContentSteering follows and <UTCTiming.