Repository navigation
Extract filename extensions from the basename - #154
Open
Ychris12138 wants to merge 1 commit into
Open
Ychris12138 wants to merge 1 commit into
Ychris12138 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext_from_filename("directory.with.dots/README") currently returns ".dots/readme", treating part of the parent directory as the file extension. from_file() and the filename-hint APIs all use this helper.
Take the basename before splitting the extension. Add eight cases for str and Path inputs to verify extensionless names, case normalization, recognized double extensions, and existing dotfile behavior inside dotted directories.
Validation on Python 3.12: 103 tests passed (the two extensionless-path cases fail before the fix); Ruff check/format and git diff --check passed. The test suite rewrites its CRLF text fixture; that generated change was restored and is not part of this PR.
AI-assisted implementation; all reported checks were executed locally.