fix RemoteAccessServicesTest: version-stream-aware pattern#70
Merged
stevebeattie merged 2 commits intochainguard-dev:mainfrom Apr 3, 2026
Merged
Conversation
Missing $ anchor on the package name pattern caused samba-libs and samba-util-libs (Kerberos/LDAP/GSSAPI shared libs pulled in as transitive dependencies of repmgr) to match the samba prefix check, generating 46 false-positive No_Remote_Access failures for postgres-14-repmgr-iamguarded-fips.
stevebeattie
previously requested changes
Mar 31, 2026
Member
stevebeattie
left a comment
stevebeattie
left a comment
There was a problem hiding this comment.
It's correct to note that with the lack of the trailing anchor, the pattern will match more things than just the packages listed; however the proposed fix will match those packages and superfluously trailing -s.
Because we do have version-streamed packages, we should probably adjust the regex to look for version-streamed variants. That said, the existing regex did not do this correctly either (e.g. wouldn't match mysql-9.4-client).
jakeva
changed the title
jakeva
changed the title
jakeva
changed the title
stevebeattie
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-*suffix in the package pattern was doing nothing useful (zero or more literal dashes), and without a$anchor, packages likesamba-libsandsamba-util-libsmatchedsambaas a prefix, causing false-positive No_Remote_Access failures.Replaces the suffix with
(-\d[\d.]*(-[a-z][a-z0-9-]*)?)?$to correctly handle version-streamed variants (openssh-9.4,samba-4.19-client) while rejecting alphabetic-only suffixes like-libsor-keysign.