Conversation
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
|
Check dagger though, youn might not want to upgrade it |
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extras/dagger/go.mod">
<violation number="1" location="extras/dagger/go.mod:52">
P2: These replace directives pin the OTel log packages back to 0.16.0, so the upgrade above never takes effect.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
@javirln you have the background on those pinned dependencies. Please take over this upgrade. |
|
I'll check the Dagger issues |
There was a problem hiding this comment.
2 issues found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="dagger.json">
<violation number="1">
P2: This downgrades the published Dagger module from v0.20.1 to v0.19.3, so remote consumers will start resolving an older engine unless that regression is intentional and documented.
(Based on your team's feedback about cross-component and version compatibility.) [FEEDBACK_USED]</violation>
</file>
<file name="extras/dagger/go.mod">
<violation number="1">
P1: This downgrades the Dagger submodule's minimum Go/toolchain version back to 1.24.0, which undercuts the repo-wide 1.26.x security upgrade this PR is meant to apply.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/skills/upgrading-golang/SKILL.md">
<violation number="1" location=".claude/skills/upgrading-golang/SKILL.md:54">
P2: This change drops the GitHub Actions update step, so the Go upgrade instructions are now incomplete and can leave CI running the old Go version.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ``` | ||
|
|
||
| ### 6. Update Documentation | ||
| ### 5. Update Documentation |
There was a problem hiding this comment.
P2: This change drops the GitHub Actions update step, so the Go upgrade instructions are now incomplete and can leave CI running the old Go version.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .claude/skills/upgrading-golang/SKILL.md, line 54:
<comment>This change drops the GitHub Actions update step, so the Go upgrade instructions are now incomplete and can leave CI running the old Go version.</comment>
<file context>
@@ -51,35 +51,26 @@ With:
-```
-
-### 6. Update Documentation
+### 5. Update Documentation
Update the version reference in `./CLAUDE.md` under "Key Technologies":
</file context>
Upgrade latest golang to get rid of some CVEs.