fix: PR metadata temp file missing .json extension#2846
Open
migmartri wants to merge 2 commits intochainloop-dev:mainfrom
Open
fix: PR metadata temp file missing .json extension#2846migmartri wants to merge 2 commits intochainloop-dev:mainfrom
migmartri wants to merge 2 commits intochainloop-dev:mainfrom
Conversation
Add wildcard to os.CreateTemp pattern so the random suffix is inserted before the extension instead of appended after it. Closes chainloop-dev#2845 Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
matiasinsaurralde
approved these changes
Mar 14, 2026
jiparis
approved these changes
Mar 14, 2026
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> # Conflicts: # pkg/attestation/crafter/crafter.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.CreateTemppattern for PR/MR metadata files so the random suffix is placed before.jsoninstead of after it (e.g.pr-metadata-123<rand>.jsoninstead ofpr-metadata-123.json<rand>).jsonextensionCloses #2845