feat: add material size annotation to attestations#2850
Merged
migmartri merged 1 commit intochainloop-dev:mainfrom Mar 14, 2026
Merged
feat: add material size annotation to attestations#2850migmartri merged 1 commit intochainloop-dev:mainfrom
migmartri merged 1 commit intochainloop-dev:mainfrom
Conversation
Closes chainloop-dev#2847 Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/attestation/crafter/materials/materials.go">
<violation number="1" location="pkg/attestation/crafter/materials/materials.go:170">
P2: This size annotation is dropped for file-based crafters that reinitialize `m.Annotations` after `uploadAndCraft`, so SPDX/SARIF/CSAF materials will not emit `chainloop.material.size`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| material.GetArtifact().Content = content | ||
| } | ||
|
|
||
| material.Annotations = map[string]string{ |
There was a problem hiding this comment.
P2: This size annotation is dropped for file-based crafters that reinitialize m.Annotations after uploadAndCraft, so SPDX/SARIF/CSAF materials will not emit chainloop.material.size.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At pkg/attestation/crafter/materials/materials.go, line 170:
<comment>This size annotation is dropped for file-based crafters that reinitialize `m.Annotations` after `uploadAndCraft`, so SPDX/SARIF/CSAF materials will not emit `chainloop.material.size`.</comment>
<file context>
@@ -165,6 +167,10 @@ func uploadAndCraft(ctx context.Context, input *schemaapi.CraftingSchema_Materia
material.GetArtifact().Content = content
}
+ material.Annotations = map[string]string{
+ AnnotationMaterialSize: strconv.FormatInt(result.size, 10),
+ }
</file context>
jiparis
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainloop.material.sizebuilt-in annotation that records the material size in byteschainloop.material.*annotation naming conventionExample output after adding a material:
In the final in-toto attestation:
Closes #2847