Skip to content

Add support to propagate args to the connection and other code clean ups#23

Open
ahmedriza wants to merge 2 commits intochdb-io:mainfrom
ahmedriza:feature/propagate-session-arguments
Open

Add support to propagate args to the connection and other code clean ups#23
ahmedriza wants to merge 2 commits intochdb-io:mainfrom
ahmedriza:feature/propagate-session-arguments

Conversation

@ahmedriza
Copy link
Copy Markdown

@ahmedriza ahmedriza commented Apr 3, 2026

Add support for propagating Session arguments to the chdb connection. This is essential when TLS configuration is required (for example when using the remoteSecure table function).

Clean up code in SessionBuilder::build, Connection::open, remove unmaintainted dev dependency tempdir (replaced with tempfile) and add more tests.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 3, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ahmedriza
Copy link
Copy Markdown
Author

ahmedriza commented Apr 4, 2026

Reverted the tempdir removal. It looks like tempfile is causing SIGSEGV when loading libchdb.so in integration tests on Linux. Doesn't happen on Mac OS. I am not entirely sure why.

Also, note that the same thing happens on the current main branch too, if we try to use tempfile instead of tempdir. So it has nothing to do with any changes on this branch. In fact, the SIGSEGV happens before any Rust code is executed at all.

@wudidapaopao
Copy link
Copy Markdown
Contributor

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants