Add support to propagate args to the connection and other code clean ups#23
Open
ahmedriza wants to merge 2 commits intochdb-io:mainfrom
Open
Add support to propagate args to the connection and other code clean ups#23ahmedriza wants to merge 2 commits intochdb-io:mainfrom
ahmedriza wants to merge 2 commits intochdb-io:mainfrom
Conversation
|
|
Author
|
Reverted the Also, note that the same thing happens on the current |
Contributor
|
Thanks for contributing! |
wudidapaopao
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for propagating
Sessionarguments to thechdbconnection. This is essential when TLS configuration is required (for example when using theremoteSecuretable function).Clean up code in
SessionBuilder::build,Connection::open, remove unmaintainted dev dependencytempdir(replaced withtempfile) and add more tests.