Provide more information/context in exceptions#37
Open
ItMightBeKaraoke wants to merge 2 commits into
Open
Conversation
In parse_file, add line number and contents to the exception when a line fails to parse so the user has enough information to diagnose the issue.
In Color.from_ass, have the color failure message show the string that fails to parse as a color (so the user can easily see what the issue was, e.g. stray whitespace). Also in LineSection.add_line, put the failing string in quotes so it's more clear it's a literal string from the document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, many of the exception messages do not provide specifics about the error. This PR adds line number and contents to exceptions from Document.parse_file, and improves some additional exception messages.