perf: replace N+1 order fetching with batched server-side endpoint#85
Merged
Conversation
When the user already has a timeslot and navigates to the pickup step, the UI now clearly indicates they are changing their timeslot: TimeslotSelector: - New optional currentTimeslot prop - Shows an orange 'CURRENT TIMESLOT' card at the top with the existing date/time when changing - Heading changes to 'Change Pickup Timeslot' vs 'Select a Pickup Timeslot' - Button text changes to 'Update Timeslot' / 'Updating...' vs 'Confirm Timeslot' / 'Confirming...' OrderSteps: - Passes orderDetails.pickupTimeslot to TimeslotSelector - Heading changes to 'Change Pickup Time' vs 'Select Pickup Time' - Description text adapts accordingly
Replace the date heading in the 'CURRENT TIMESLOT' card with the pickup instruction profile name and short summary (e.g. the pickup method/location) since the date is already visible in the timeslot list below. The card now shows: - Time range and label - Pickup type name with optional short summary
The OrdersByTimeslotView dashboard was making ~52 sequential HTTP requests (1 per timeslot + 1 for unassigned orders). This replaces that with a single API call to a new /api/admin/orders-by-timeslot endpoint that: - Fetches all active timeslots in 1 DB query - Fetches all assigned + unassigned orders in 2 parallel DB queries - Groups orders by timeslot server-side Reduces network round-trips from ~52 to 1 and DB queries from ~52 to 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
OrdersByTimeslotViewadmin dashboard was making ~52 sequential HTTP requests to load data — one to fetch timeslots, then one per timeslot to fetch its orders (in a sequentialforloop), plus one for unassigned orders. With ~50 slots per week, this was extremely slow.Solution
New dedicated
/api/admin/orders-by-timeslotendpoint that does everything server-side:inoperator + unassigned PAID orders)The component now makes a single
fetch()call instead of ~52.Changes
app/api/admin/orders-by-timeslot/route.ts— admin-authenticated batched endpointcomponents/admin/OrdersByTimeslotView.tsx— replaced N+1 fetch loop with single API call