Skip to content

Fix welcome screen event#1778

Closed
irkedMATT wants to merge 7 commits into
chsami:developmentfrom
irkedMATT:FixWelcomeScreenEvent
Closed

Fix welcome screen event#1778
irkedMATT wants to merge 7 commits into
chsami:developmentfrom
irkedMATT:FixWelcomeScreenEvent

Conversation

@irkedMATT
Copy link
Copy Markdown
Contributor

fix(events): update WelcomeScreenEvent validation logic

Updated the WelcomeScreenEvent validation to return false if the player is already logged in. This prevents the event from attempting to trigger when the welcome screen is no longer relevant.

chsami and others added 7 commits May 8, 2026 19:51
Merge development into main for 1.12.26.2 / Microbot 2.5.5
fix(build): bump project version to 1.12.26.2
2.5.9 League walker + walker changes
Updated the `WelcomeScreenEvent` validation to return false if the player is already logged in. This prevents the event from attempting to trigger when the welcome screen is no longer relevant.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ac2cf2e3-a02f-4f8a-84a9-3bfa58f9d1b0

📥 Commits

Reviewing files that changed from the base of the PR and between 9fda631 and 24316d8.

📒 Files selected for processing (1)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/WelcomeScreenEvent.java

Walkthrough

This PR adds an early-exit guard clause to WelcomeScreenEvent.validate(). When Microbot.isLoggedIn() returns true, the method now immediately returns false instead of proceeding to check whether the Welcome Screen "PLAY" widget is visible. This prevents the event validation from continuing while the user is already logged in.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change—fixing the welcome screen event validation logic to check login status.
Description check ✅ Passed The description is directly related to the changeset, providing relevant context about updating validation logic to prevent triggering when already logged in.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@irkedMATT irkedMATT closed this May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants