Repository navigation
feat: add std::span support for C++20 builds - #99
Open
k-wasniowski wants to merge 3 commits into
Open
k-wasniowski wants to merge 3 commits into
k-wasniowski wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add <stdexcept> directly and test a C++20 consumer build.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds C++20 std::span support while retaining gsl_lite::span for older standards.
Changes:
- Adds conditional span selection.
- Updates public byte-view aliases.
- Removes the direct public
gslnamespace dependency.
| File | Summary |
|---|---|
include/sframe/span.h |
Selects std::span or gsl_lite::span; C++20 consumer coverage is missing. |
include/sframe/sframe.h |
Uses compatibility span aliases; needs a direct <stdexcept> include. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
k-wasniowski
force-pushed
the
sframe-v1-spanify
branch
from
September 23, 2026 09:11
e23f7ac to
7e60b95
Compare
k-wasniowski
force-pushed
the
sframe-v1-spanify
branch
from
September 28, 2026 07:57
a9d6497 to
e79c047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add
std::spansupport for C++20 buildsSummary
Uses
std::spanfor the public byte-view types when building with C++20 and retainsgsl_lite::spanas the fallback for older language standards.This backports the span compatibility layer from the main branch to the v1 branch.
Changes
include/sframe/span.hto select the available span implementation:std::spanwhen supported by the standard library.gsl_lite::spanfor pre-C++20 builds.include/sframe/sframe.hto use the compatibilityspanalias forinput_bytesandoutput_bytes.gslnamespace alias.Compatibility
gsl_lite::span.std::spanwithout API changes toinput_bytesoroutput_bytes.Validation
sframetarget using the project's configured C++11 mode.input_bytesandoutput_bytesresolve to the correspondingstd::spantypes.git diff --check.