feat: add ALIAS_DOMAIN / SAN support for all DNS providers#3
Closed
feat: add ALIAS_DOMAIN / SAN support for all DNS providers#3
Conversation
When ALIAS_DOMAIN is set: - certbot issues a SAN cert covering both DOMAIN and ALIAS_DOMAIN - nginx server_name includes ALIAS_DOMAIN - Works with all DNS providers (Cloudflare, Linode, Namecheap, Route53) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
--cert-name is only needed when --expand adds a SAN, to prevent certbot from creating a suffixed cert directory. Without ALIAS_DOMAIN certbot already names the cert after the -d domain by default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Superseded by upstream Dstack-TEE#86 Note: upstream PR Dstack-TEE#86 has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ALIAS_DOMAINenvironment variable support to dstack-ingress. When set:DOMAINandALIAS_DOMAIN(via--cert-name+--expand -d)server_nameincludesALIAS_DOMAINso requests arriving via either hostname are acceptedThis works with all DNS providers (Cloudflare, Linode, Namecheap, Route53) — no provider-specific code needed.
New Environment Variable
ALIAS_DOMAINserver_nameFiles Changed
scripts/certman.py--cert-name,--expand -d alias_domainto certbot commandscripts/entrypoint.shALIAS_DOMAIN, include in nginxserver_nameDNS_PROVIDERS.mdALIAS_DOMAINin optional variablesREADME.mdALIAS_DOMAINenv varTest plan
ALIAS_DOMAIN=alias.example.com— verify cert has SAN for both domainsserver_nameincludes both domainsALIAS_DOMAIN— verify behavior identical to beforeCherry-picked from Dstack-TEE/dstack-examples#83
Tracks: CPL-139
🤖 Generated with Claude Code