🍕 chore(icons): replace placeholder S logo with Clay icon everywhere#10
Merged
Conversation
The toolbar icon, chrome://extensions tile, and Web Store listing have
been showing a generic red "S" placeholder since v1. The actual Clay
character lives at src/assets/clay-icon.png and was already used for
the FAB and the in-page panel header — but not for the browser-chrome
surfaces. This unifies the brand: the same character now appears
everywhere the user sees the extension.
What changed
- public/icons/icon-{16,32,48,128}.png regenerated from clay-icon.png:
- 32 / 48 / 128 sized straight from the 200×200 source so they
keep the cute floating-in-space padding.
- 16 cropped to 160×160 first so the character's head + face fill
the toolbar slot instead of vanishing into transparent padding.
- src/popup/Popup.tsx + popup.css: drop the colored-square + "S"
letter, render <img src=clay-icon.png?inline> instead.
- src/options/Options.tsx + options.css: same swap in the settings
page header.
The manifest already pointed at icons/icon-*.png, so no manifest
changes were needed — Chrome picks up the new bytes on the next
reload. The popup/options use the ?inline asset URL (base64 data URL)
to sidestep any path-resolution gotchas in extension-internal pages,
matching the FAB and Header pattern.
No test or behavior changes; visual only. Full suite stays green at
113/113.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The toolbar icon, `chrome://extensions` tile, and Web Store listing have been showing a generic red S placeholder since v1. The actual Clay character (the one used for the FAB and the in-page panel header) wasn't wired into the browser-chrome surfaces. This unifies the brand — the same character now appears everywhere the user sees the extension.
What changed
Files
Why ?inline for the popup/options
The popup and options bundles are extension-internal pages, so a normal asset import would also work. Using `?inline` (base64 data URL) keeps them consistent with the FAB and Header (which need it because they're injected into the host page's Shadow DOM), and sidesteps any future path-resolution surprises if someone refactors the bundles.
Test plan
No manifest changes were needed — Chrome picks up the new icon bytes on the next reload.
Made with Cursor