Skip to content

support enteprise account linking#8091

Draft
NicolasLopes7 wants to merge 1 commit intomainfrom
nicolas/enterprise-connections-account-linking
Draft

support enteprise account linking#8091
NicolasLopes7 wants to merge 1 commit intomainfrom
nicolas/enterprise-connections-account-linking

Conversation

@NicolasLopes7
Copy link
Contributor

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 16, 2026 10:44pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2026

⚠️ No Changeset found

Latest commit: 76f2d4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NicolasLopes7 NicolasLopes7 changed the title wip support enteprise account linking Mar 16, 2026
successMessage: 'The provider has been added to your account',
title: 'Add connected account',
},
enterpriseAccountPage: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generate the translations on all localizations file via LLM prompt?

isLoading={card.loadingMetadata === loadingKey}
focusRing={false}
closeAfterClick={false}
localizationKey={localizationKeys('userProfile.connectedAccountPage.socialButtonsBlockButton', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
localizationKey={localizationKeys('userProfile.connectedAccountPage.socialButtonsBlockButton', {
localizationKey={localizationKeys('userProfile.enterpriseAccountPage.socialButtonsBlockButton', {

Let's use an specific translation key for the enterprise accounts section

);
};

const AddEnterpriseAccount = ({
Copy link
Member

@LauraBeatris LauraBeatris Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const AddEnterpriseAccount = ({
const ConnectEnterpriseAccounts = ({

Since this component receives a list of enterprise accounts + it has a inner menu to connect to it

Comment on lines +144 to +146
user?.getEnterpriseConnections?.().then(connections => {
setEnterpriseConnections(connections.filter(c => c.allowAccountLinking));
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use our data fetching hooks for it

);

if (!activeEnterpriseAccounts?.length) {
const hasActiveAccounts = Boolean(activeEnterpriseAccounts?.length);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this simpler by using some above on activeEnterpriseAccounts


if (!activeEnterpriseAccounts?.length) {
const hasActiveAccounts = Boolean(activeEnterpriseAccounts?.length);
const hasAvailableConnections = enterpriseConnections.length > 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const hasAvailableConnections = enterpriseConnections.length > 0;
const hasAvailableConnectionsForAccountLinking = enterpriseConnectionsForAccountLinking.length > 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants